diff options
| author | Ava Chow <github@achow101.com> | 2024-06-04 18:37:18 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-06-04 18:37:18 -0400 |
| commit | 701b0cf2f33c65961374bb0e13e4481cfc0f3d01 (patch) | |
| tree | c71eb8a7c867452df950aa7026dfdec5bbdd58a9 /src/wallet/rpc/spend.cpp | |
| parent | d39f15a8a5b06d68070a3434a81c6840d4f87715 (diff) | |
| parent | bd34dd85e7b8b4cc26d2173d84bbeda2e9c27624 (diff) | |
| download | bitcoin-701b0cf2f33c65961374bb0e13e4481cfc0f3d01.tar.xz | |
Merge bitcoin/bitcoin#28366: Fix waste calculation in SelectionResult
bd34dd85e7b8b4cc26d2173d84bbeda2e9c27624 Use `exact_target` shorthand in coinselector_tests (Murch)
7aa7e30441fe77bf8e8092916e36b004bbbfe2a7 Fold GetSelectionWaste() into ComputeAndSetWaste() (Murch)
Pull request description:
PR #26152 moved waste calculation into SelectionResult to be able to correct the waste score on basis of the bump_fee_group_discount for overlapping ancestries. This left two functions with largely overlapping purpose, where one was simply a wrapper of the other. This PR cleans up the overlap, and fixes the double-meaning of `change_cost` where the `GetChange()` function assumed that no change was created when `change_cost` was set to 0. This behavior was exploited in a bunch of tests, but is problematic, because a `change_cost` of 0 is permitted with custom settings for feerate and discard_feerate (i.e. when they’re both 0).
ACKs for top commit:
achow101:
ACK bd34dd85e7b8b4cc26d2173d84bbeda2e9c27624
furszy:
Code ACK bd34dd85e7b8b4cc26d2173d84bbeda2e9c27624
ismaelsadeeq:
Code Review ACK bd34dd85e7b8b4cc26d2173d84bbeda2e9c27624
Tree-SHA512: 83a2688d45d719dc61a64b5180fe136107faccf401a59df65245c05d701748a03e85ed56fde8c9b7ef39a3ab54374dd3718c559bda5b3f55dafedfd7fed25161
Diffstat (limited to 'src/wallet/rpc/spend.cpp')
0 files changed, 0 insertions, 0 deletions