diff options
author | MacroFake <falke.marco@gmail.com> | 2022-08-05 10:49:12 +0200 |
---|---|---|
committer | MacroFake <falke.marco@gmail.com> | 2022-08-05 10:51:06 +0200 |
commit | 7d82f86341072311a0e62807213e17925efde299 (patch) | |
tree | fbd4c0b621128f9e751c8f2b761c36239f38c9d0 /src/wallet/rpc/signmessage.cpp | |
parent | e03860558581adda52949e1fd3ed3f923e7c49e7 (diff) | |
parent | 21a9e94dbbc47939f19fbfe39d85cb8ff2ea206a (diff) | |
download | bitcoin-7d82f86341072311a0e62807213e17925efde299.tar.xz |
Merge bitcoin/bitcoin#25650: script: default to necessary tags in `test/get_previous_releases.py`
21a9e94dbbc47939f19fbfe39d85cb8ff2ea206a ci: remove hardcoded tag list from ci scripts (josibake)
d530ba390e7703433d3a77673c9a2b52bc446901 doc: update test/README.md (josibake)
614d4682badaadac74b825a45aaee9c2309a3e81 script: default to necessary tags in get_previous_releases.py (josibake)
Pull request description:
Almost every time I need to use this script, I forget the tag list is needed and that a specific set of tags is needed for the backwards compatibility tests to work. I end up wasting time reading through the script and googling to find the tag list before remembering it is in `test/README.md`
I assume (hope) I'm not the only one this happens to, so I figured it would make more sense to have the script default to downloading/building the necessary tags. This has the added benefit of making the script the source of truth: the script already needs to be updated with the SHA256_SUM of the binary for every new tag that is added, so it makes sense to use `SHA256_SUMS` list as the necessary tag list. This means there is less risk of the README and the script drifting (i.e updating the readme with a new tag and forgetting to update the script, or updating the script and forgetting to update the README). Now all that needs to happen is to update the `SHA256_SUMS` list in the script and everything Just Works (TM)
ACKs for top commit:
Sjors:
re-tACK 21a9e94dbbc47939f19fbfe39d85cb8ff2ea206a
Tree-SHA512: 97b488227a89a6827584edd251820a7074fad75dfd7f26f1aa5f858e2521d2e02effd0f11e6dc4676e1155d3d5aba6ff94a4b58ffef80dc201376afd5927deb9
Diffstat (limited to 'src/wallet/rpc/signmessage.cpp')
0 files changed, 0 insertions, 0 deletions