diff options
author | fanquake <fanquake@gmail.com> | 2023-11-14 09:42:12 +0000 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2023-11-14 09:47:36 +0000 |
commit | fb85bb277670aad28fef51b7313d4a96cdaa760f (patch) | |
tree | 0a6df27a65ed2857fef0b1f8e16f3cd949e38035 /src/wallet/feebumper.cpp | |
parent | 1fbeeed23a77cb42d6e2531d4d9e898a41049c86 (diff) | |
parent | 3c61c60b90db1b6a77b3804784430fcd57b447b6 (diff) |
Merge bitcoin/bitcoin#28783: build: remove `-bind_at_load` usage
3c61c60b90db1b6a77b3804784430fcd57b447b6 build: Add an old hack to remove bind_at_load from libtool. (Cory Fields)
45257601da4cf38f081d9af2c18cd0be7174bcef build: remove -bind_at_load usage (fanquake)
Pull request description:
This is deprecated on macOS:
```bash
ld: warning: -bind_at_load is deprecated on macOS
```
and likely redundant anyways, given the behaviour of dyld3.
Unfortunately libtool is still injecting a `-bind_at_load`, because it's version check is broken:
```bash
# Don't allow lazy linking, it breaks C++ global constructors
# But is supposedly fixed on 10.4 or later (yay!).
if test CXX = "$tagname"; then
case ${MACOSX_DEPLOYMENT_TARGET-10.0} in
10.[0123])
func_append compile_command " $wl-bind_at_load"
func_append finalize_command " $wl-bind_at_load"
;;
esac
fi
```
so this adds another change to strip them out at the end of configure.
Note that anywhere the ld64 warnings are being emitted, we are already not adding this flag to our hardened ldflags, because of `-Wl,-fatal_warnings`.
ACKs for top commit:
theuni:
utACK 3c61c60b90db1b6a77b3804784430fcd57b447b6.
hebasto:
ACK 3c61c60b90db1b6a77b3804784430fcd57b447b6, tested on macOS Sonoma 14.1.1 (23B81, Apple M1) and Ubuntu 23.10 (cross-compiling for macOS). Also I've verified the actual diff in the `libtool` script.
Tree-SHA512: 98e6a095dc2d2409f8ec3b9d462e0db3643d7873d7903a12f8acd664829e7e84e797638556fa42ca8ebc1003f13a38fe9bb8a2a50cecfa991155da818574bf08
Diffstat (limited to 'src/wallet/feebumper.cpp')
0 files changed, 0 insertions, 0 deletions