diff options
author | glozow <gloriajzhao@gmail.com> | 2022-09-28 14:31:20 +0100 |
---|---|---|
committer | glozow <gloriajzhao@gmail.com> | 2023-01-10 11:09:03 +0000 |
commit | 5eab397b9840de5a4729bea723794b529e5fcbb4 (patch) | |
tree | 6a4d084470ab5b1d74fc1d15ed8e4d08e85e341c /src/validation.h | |
parent | 601bac88cb95404e7d38ac6348d959c0e06bd922 (diff) |
[validation] remove PackageMempoolAcceptResult::m_package_feerate
This value creates an extremely confusing interface as its existence is
dependent upon implementation details (whether something was submitted
on its own, etc). MempoolAcceptResult::m_effective_feerate is much more
helpful, as it always exists for submitted transactions.
Diffstat (limited to 'src/validation.h')
-rw-r--r-- | src/validation.h | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/validation.h b/src/validation.h index 6746ca1c5e..900f380563 100644 --- a/src/validation.h +++ b/src/validation.h @@ -216,10 +216,6 @@ struct PackageMempoolAcceptResult * was a package-wide error (see result in m_state), m_tx_results will be empty. */ std::map<const uint256, const MempoolAcceptResult> m_tx_results; - /** Package feerate, defined as the aggregated modified fees divided by the total virtual size - * of all transactions in the package. May be unavailable if some inputs were not available or - * a transaction failure caused validation to terminate early. */ - std::optional<CFeeRate> m_package_feerate; explicit PackageMempoolAcceptResult(PackageValidationState state, std::map<const uint256, const MempoolAcceptResult>&& results) @@ -227,7 +223,7 @@ struct PackageMempoolAcceptResult explicit PackageMempoolAcceptResult(PackageValidationState state, CFeeRate feerate, std::map<const uint256, const MempoolAcceptResult>&& results) - : m_state{state}, m_tx_results(std::move(results)), m_package_feerate{feerate} {} + : m_state{state}, m_tx_results(std::move(results)) {} /** Constructor to create a PackageMempoolAcceptResult from a single MempoolAcceptResult */ explicit PackageMempoolAcceptResult(const uint256& wtxid, const MempoolAcceptResult& result) |