diff options
| author | fanquake <fanquake@gmail.com> | 2024-03-05 11:00:54 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2024-03-05 11:16:59 +0000 |
| commit | 2b260eadf7960290328e13dbdb029fd506105ca4 (patch) | |
| tree | 8e49a306d3999e04bd6180411faa10268984ae07 /src/validation.h | |
| parent | 98005b6a17907c4f7bdcf802ee96c274492f902a (diff) | |
| parent | e67ab174c9c04bba7a10724b7e694dd57f732177 (diff) | |
Merge bitcoin/bitcoin#29502: test: modify weight estimate in functional tests
e67ab174c9c04bba7a10724b7e694dd57f732177 test: fix flaky wallet_send functional test (Max Edwards)
3c49e6967050cfc367b3c826c9eac86a48528af5 test: fix weight estimates in functional tests (Max Edwards)
Pull request description:
Fixes: https://github.com/bitcoin/bitcoin/issues/25164
The wallet_send functional test has been flaky due to a slightly overestimated weight calculation. This PR makes the weight calculation more accurate, although occasionally, due to how ECDSA signatures can be different lengths it might slightly over estimate. The assertion in the test can handle this slight variation and so should continue passing.
Update:
Because the signature can be shorter that is used in the weight estimation or the final transaction the estimate could be both slightly smaller or slightly larger.
ACKs for top commit:
achow101:
ACK e67ab174c9c04bba7a10724b7e694dd57f732177
S3RK:
Code review ACK e67ab174c9c04bba7a10724b7e694dd57f732177
Tree-SHA512: 3bf73b355309dce860fa1520afb8461e94268e4bcf0e92a8273c279b41b058c44472cf59daafa15a515529b50bd665b5d498bbe4d934f2315dbe810a05bc73f9
Diffstat (limited to 'src/validation.h')
0 files changed, 0 insertions, 0 deletions