diff options
author | laanwj <126646+laanwj@users.noreply.github.com> | 2022-06-28 15:09:55 +0200 |
---|---|---|
committer | laanwj <126646+laanwj@users.noreply.github.com> | 2022-06-28 15:10:00 +0200 |
commit | 55c9e2d790fa2e137ccd0d91e6cf3e2d0bff4813 (patch) | |
tree | 9d8d24f90f80954a53134582cb42b0f1bae6cfca /src/util/sock.h | |
parent | ba29911e21c88f49780c6c87f94ff8ed6e764a9d (diff) | |
parent | b2733ab6a85b234a88b83bdc77a0d043e18385b3 (diff) | |
download | bitcoin-55c9e2d790fa2e137ccd0d91e6cf3e2d0bff4813.tar.xz |
Merge bitcoin/bitcoin#24378: refactor: make bind() and listen() mockable/testable
b2733ab6a85b234a88b83bdc77a0d043e18385b3 net: add new method Sock::Listen() that wraps listen() (Vasil Dimov)
3ad7de225efce3e76530f56bee8a8f7a75ea0f3c net: add new method Sock::Bind() that wraps bind() (Vasil Dimov)
Pull request description:
_This is a piece of #21878, chopped off to ease review._
Add new methods `Sock::Bind()` and `Sock::Listen()` that wrap `bind()` and `listen()`.
This will help to increase `Sock` usage and make more code mockable.
ACKs for top commit:
pk-b2:
ACK b2733ab6a85b234a88b83bdc77a0d043e18385b3
laanwj:
Code review ACK b2733ab6a85b234a88b83bdc77a0d043e18385b3
Tree-SHA512: c6e737606703e2106fe60cc000cfbbae3a7f43deadb25f70531e2cac0457e0b0581440279d14c76c492eb85c12af4adde52c30baf74542c41597e419817488e8
Diffstat (limited to 'src/util/sock.h')
-rw-r--r-- | src/util/sock.h | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/src/util/sock.h b/src/util/sock.h index 73ceb0b62c..b854609c22 100644 --- a/src/util/sock.h +++ b/src/util/sock.h @@ -87,6 +87,18 @@ public: [[nodiscard]] virtual int Connect(const sockaddr* addr, socklen_t addr_len) const; /** + * bind(2) wrapper. Equivalent to `bind(this->Get(), addr, addr_len)`. Code that uses this + * wrapper can be unit tested if this method is overridden by a mock Sock implementation. + */ + [[nodiscard]] virtual int Bind(const sockaddr* addr, socklen_t addr_len) const; + + /** + * listen(2) wrapper. Equivalent to `listen(this->Get(), backlog)`. Code that uses this + * wrapper can be unit tested if this method is overridden by a mock Sock implementation. + */ + [[nodiscard]] virtual int Listen(int backlog) const; + + /** * accept(2) wrapper. Equivalent to `std::make_unique<Sock>(accept(this->Get(), addr, addr_len))`. * Code that uses this wrapper can be unit tested if this method is overridden by a mock Sock * implementation. |