diff options
| author | Ava Chow <github@achow101.com> | 2024-05-02 16:33:18 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-05-02 16:33:18 -0400 |
| commit | 81174d8a9b8060b35341d88d3b54c08d9f2bb079 (patch) | |
| tree | dd885f79349068a300c8feca18342621ebded0c7 /src/util/fastrange.h | |
| parent | 3d28725134df09768780249dc1d974b9cdcc83f1 (diff) | |
| parent | 8b52e7f628304e83b0e36fd97e617de0f71c5a62 (diff) | |
Merge bitcoin/bitcoin#29961: refactor: remove remaining unused code from cpp-subprocess
8b52e7f628304e83b0e36fd97e617de0f71c5a62 update comments in cpp-subprocess (check_output references) (Sebastian Falbesoner)
97f159776ec06f767df1d4990aa7d0859140f52f remove unused method `Popen::kill` from cpp-subprocess (Sebastian Falbesoner)
908c51fe4afeba0af500c6275027b1afa1b3bd19 remove commented out code in cpp-subprocess (Sebastian Falbesoner)
ff79adbe056220202f7a56d67f788c38fc49ef9f remove unused templates from cpp-subprocess (Sebastian Falbesoner)
Pull request description:
This PR removes remaining code that is unused within the cpp-subprocess module (templates and commented out code). Happy to add more removals if anyone finds more unused parts. Note that there are some API functions of the `Popen` class that we don't use, e.g. `wait()`, `pid()`, `poll()`, `kill()`, but they sound IMHO common enough to be useful in the future, so not sure how deep we should go there.
ACKs for top commit:
fjahr:
Code review ACK 8b52e7f628304e83b0e36fd97e617de0f71c5a62
achow101:
ACK 8b52e7f628304e83b0e36fd97e617de0f71c5a62
hebasto:
ACK 8b52e7f628304e83b0e36fd97e617de0f71c5a62.
Tree-SHA512: 14c1cd2216185d941923f06fdc7acbeed66cd87e2691d9a352f7309b3e07fe4877b580f598a2e4106f9c48395ed6de00a0bfb5d3c3af9c4624d1956a0f543e99
Diffstat (limited to 'src/util/fastrange.h')
0 files changed, 0 insertions, 0 deletions