scripted-diff: Rename SetHex to SetHexDeprecated

SetHex is fragile, because it accepts any non-hex input or any length of
input, without error feedback. This can lead to issues when the input is
truncated or otherwise corrupted.

Document the problem by renaming the method.

In the future, the fragile method should be removed from the public
interface.

-BEGIN VERIFY SCRIPT-
 sed -i 's/SetHex/SetHexDeprecated/g' $( git grep -l SetHex ./src )
-END VERIFY SCRIPT-

1 files changed, 2 insertions, 2 deletions

diff --git a/src/uint256.h b/src/uint256.h
index 406a9c7203..3f7dce6983 100644
--- a/src/uint256.h
+++ b/src/uint256.h
@@ -59,7 +59,7 @@ public:
 
     // Hex string representations are little-endian.
     std::string GetHex() const;
-    void SetHex(std::string_view str);
+    void SetHexDeprecated(std::string_view str);
     std::string ToString() const;
 
     constexpr const unsigned char* data() const { return m_data.data(); }
@@ -119,7 +119,7 @@ public:
 inline uint256 uint256S(std::string_view str)
 {
     uint256 rv;
-    rv.SetHex(str);
+    rv.SetHexDeprecated(str);
     return rv;
 }