diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-07-03 13:01:45 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-07-03 13:02:41 +0200 |
| commit | 7f985d6c8159f377b685ec2f404f733bdae6ac58 (patch) | |
| tree | 946a9d1363454f19204ed8c179aca836dbf1713d /src/uint256.cpp | |
| parent | 7d7b832d6707299bde20e3b62247538443af4012 (diff) | |
| parent | f53a70ce95231d34bb14cd6c58503927e8d7ff59 (diff) | |
| download | bitcoin-7f985d6c8159f377b685ec2f404f733bdae6ac58.tar.xz | |
Merge #16158: Fix logic of memory_cleanse() on MSVC and clean up docs
f53a70ce95231d34bb14cd6c58503927e8d7ff59 Improve documentation of memory_cleanse() (Tim Ruffing)
cac30a436cab3641bba3b774d3d3ddbc426e7908 Clean up logic in memory_cleanse() for MSVC (Tim Ruffing)
Pull request description:
When working on https://github.com/bitcoin-core/secp256k1/issues/185, I noticed that the logic in memory_cleanse(), which is supposed to clear memory securely, is weird on MSVC. While it's correct, it's at least a code smell because the code clears the memory twice on MSVC. This weirdness was introduced by #11558.
This PR fixes the logic on MSVC and also improves the docs around this function. Best reviewed in individual commits, see the commit messages for more rationale. The second commit touches only comments.
ACKs for top commit:
practicalswift:
utACK f53a70ce95231d34bb14cd6c58503927e8d7ff59 :-)
laanwj:
code review ACK f53a70ce95231d34bb14cd6c58503927e8d7ff59
Tree-SHA512: 1c2fd98ae62b34b3e6e59d1178b293af969a9e06cbb7df02a699ce8802f145a336f72edb178c520e3ecec81f7e8083828f90a5ba6367d966a2c7d7c0dd6c0475
Diffstat (limited to 'src/uint256.cpp')
0 files changed, 0 insertions, 0 deletions