diff options
| author | fanquake <fanquake@gmail.com> | 2023-12-11 15:31:51 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-12-11 15:44:16 +0000 |
| commit | d5e5810bd36f6e899d64a57e9264729b27a9c3f8 (patch) | |
| tree | 3a1c54d5bd99a6107a0196fff986f890af9c02e9 /src/txorphanage.h | |
| parent | dabd7046420501a028903a68e9f185d1e347ba3e (diff) | |
| parent | fa8adbe7c17b16cf7ecd16eb9f3f1792e9da2876 (diff) | |
Merge bitcoin/bitcoin#28999: build: Enable -Wunreachable-code
fa8adbe7c17b16cf7ecd16eb9f3f1792e9da2876 build: Enable -Wunreachable-code (MarcoFalke)
Pull request description:
It seems a bit confusing to write code after a `return`. This can even lead to bugs, or incorrect code, such as https://github.com/bitcoin/bitcoin/pull/28830/files#r1415372320 . (Edit: The linked instance is not found by clang's `-Wunreachable-code`).
Fix all issues by enabling `-Wunreachable-code`.
This flag also enables `-Wunreachable-code-loop-increment`, according to https://clang.llvm.org/docs/DiagnosticsReference.html#wunreachable-code, so remove that.
ACKs for top commit:
ajtowns:
> ACK [fa8adbe](https://github.com/bitcoin/bitcoin/commit/fa8adbe7c17b16cf7ecd16eb9f3f1792e9da2876)
stickies-v:
ACK fa8adbe7c17b16cf7ecd16eb9f3f1792e9da2876
jonatack:
ACK fa8adbe7c17b16cf7ecd16eb9f3f1792e9da2876 tested with arm64 clang 17.0.6
Tree-SHA512: 12a2f74b69ae002e62ae08038f7458837090a12051a4c154d05ae4bb26fb19fc1fa76c63aedf2b3fbb36f048c593ca3b8c0efe03fe93cf07a0fd114fc84ce1e7
Diffstat (limited to 'src/txorphanage.h')
0 files changed, 0 insertions, 0 deletions