diff options
author | MarcoFalke <falke.marco@gmail.com> | 2021-11-02 13:38:57 +0100 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2021-11-02 13:40:09 +0100 |
commit | 9e3f7dcaa2f89efff48d299132f4998bf701c264 (patch) | |
tree | 1d409ed5787848c12c9cc655a98a6ed3be933c85 /src/txmempool.cpp | |
parent | 76886ce11e85509cd9323fcff541c79e2c26034b (diff) | |
parent | f3e451bebfe2e2d8de901d8ac29c064a51d3b746 (diff) | |
download | bitcoin-9e3f7dcaa2f89efff48d299132f4998bf701c264.tar.xz |
Merge bitcoin/bitcoin#22735: [net] Don't return an optional from TransportDeserializer::GetMessage()
f3e451bebfe2e2d8de901d8ac29c064a51d3b746 [net] Replace GetID() with id in TransportDeserializer constructor (Troy Giorshev)
8c96008ab18075abca03bff6b3675643825a21ca [net] Don't return an optional from TransportDeserializer::GetMessage() (Troy Giorshev)
Pull request description:
Also, access mapRecvBytesPerMsgCmd with `at()` not `find()`. This
throws an error if COMMAND_OTHER doesn't exist, which should never
happen. `find()` instead just accessed the last element, which could make
debugging more difficult.
Resolves review comments from PR19107:
- https://github.com/bitcoin/bitcoin/pull/19107#discussion_r478718436
- https://github.com/bitcoin/bitcoin/pull/19107#discussion_r478714497
ACKs for top commit:
theStack:
Code-review ACK f3e451bebfe2e2d8de901d8ac29c064a51d3b746
ryanofsky:
Code review ACK f3e451bebfe2e2d8de901d8ac29c064a51d3b746. Changes since last review in https://github.com/bitcoin/bitcoin/pull/20364#pullrequestreview-534369904 were simplifying by dropping the third commit, rebasing, and cleaning up some style & comments in the first commit.
Tree-SHA512: 37de4b25646116e45eba50206e82ed215b0d9942d4847a172c104da4ed76ea4cee29a6fb119f3c34106a9b384263c576cb8671d452965a468f358d4a3fa3c003
Diffstat (limited to 'src/txmempool.cpp')
0 files changed, 0 insertions, 0 deletions