aboutsummaryrefslogtreecommitdiff
path: root/src/test
diff options
context:
space:
mode:
authorBtcDrak <btcdrak@gmail.com>2016-12-07 20:22:07 +0000
committerBtcDrak <btcdrak@gmail.com>2016-12-08 20:11:51 +0000
commitdab207e4e694c6980336f59817d6c9af83a46fa2 (patch)
treeebcec35326d2681f2595c855c66d1affd21beb6c /src/test
parentc5d746ace7c7bc2884c9eefa6c4c0b2c4f89cfb5 (diff)
Preserve tx version=1 for certain tests
Without this change, the tests would be affected by default tx version increases.
Diffstat (limited to 'src/test')
-rw-r--r--src/test/hash_tests.cpp6
-rw-r--r--src/test/txvalidationcache_tests.cpp1
2 files changed, 6 insertions, 1 deletions
diff --git a/src/test/hash_tests.cpp b/src/test/hash_tests.cpp
index fa9624f13d..8be9c580c4 100644
--- a/src/test/hash_tests.cpp
+++ b/src/test/hash_tests.cpp
@@ -124,7 +124,11 @@ BOOST_AUTO_TEST_CASE(siphash)
}
CHashWriter ss(SER_DISK, CLIENT_VERSION);
- ss << CTransaction();
+ CMutableTransaction tx;
+ // Note these tests were originally written with tx.nVersion=1
+ // and the test would be affected by default tx version bumps if not fixed.
+ tx.nVersion = 1;
+ ss << tx;
BOOST_CHECK_EQUAL(SipHashUint256(1, 2, ss.GetHash()), 0x79751e980c2a0a35ULL);
}
diff --git a/src/test/txvalidationcache_tests.cpp b/src/test/txvalidationcache_tests.cpp
index 55b4d28fb2..9f58f004d5 100644
--- a/src/test/txvalidationcache_tests.cpp
+++ b/src/test/txvalidationcache_tests.cpp
@@ -39,6 +39,7 @@ BOOST_FIXTURE_TEST_CASE(tx_mempool_block_doublespend, TestChain100Setup)
spends.resize(2);
for (int i = 0; i < 2; i++)
{
+ spends[i].nVersion = 1;
spends[i].vin.resize(1);
spends[i].vin[0].prevout.hash = coinbaseTxns[0].GetHash();
spends[i].vin[0].prevout.n = 0;