diff options
author | W. J. van der Laan <laanwj@protonmail.com> | 2021-06-21 11:15:11 +0200 |
---|---|---|
committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-06-21 11:15:42 +0200 |
commit | 6a67366fdc3e1d383fe7cbfa209d7e85f0d96638 (patch) | |
tree | 79e3c1f5514e18a74f3e11e47d42dfcbe7fd3b63 /src/test/util/setup_common.cpp | |
parent | f6a25bea826e559967a35cf4c7d18c7f44429d3c (diff) | |
parent | 4e353cb618745cdb5d98e58e7dcd400ded01299a (diff) | |
download | bitcoin-6a67366fdc3e1d383fe7cbfa209d7e85f0d96638.tar.xz |
Merge bitcoin/bitcoin#19033: http: Release work queue after event base finish
4e353cb618745cdb5d98e58e7dcd400ded01299a http: Release work queue after event base finish (João Barbosa)
Pull request description:
This fixes a race between `http_request_cb` and `StopHTTPServer` where
the work queue is used after release.
Fixes #18856.
ACKs for top commit:
fjahr:
Code review ACK 4e353cb618745cdb5d98e58e7dcd400ded01299a
achow101:
ACK 4e353cb618745cdb5d98e58e7dcd400ded01299a
LarryRuane:
ACK 4e353cb618745cdb5d98e58e7dcd400ded01299a
hebasto:
ACK 4e353cb618745cdb5d98e58e7dcd400ded01299a, tested (rebased on top of master 9313c4e6aa4b707c06a86b33d5d2753cd8383340) on Linux Mint 20.1 (x86_64) using MarcoFalke's [patch](https://github.com/bitcoin/bitcoin/pull/19033#issuecomment-640106647), including different `-rpcthreads`/`-rpcworkqueue` cases. The bug is fixed. The code is correct.
Tree-SHA512: 185d2a9744d0d5134d782bf321ac9958ba17b11a5b3d70b4897c8243e6b146dfd3f23c57aef8e10ae9484374120b64389c1949a9cf0a21dccc47ffc934c20930
Diffstat (limited to 'src/test/util/setup_common.cpp')
0 files changed, 0 insertions, 0 deletions