diff options
| author | fanquake <fanquake@gmail.com> | 2023-05-30 10:33:45 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-05-30 10:49:14 +0100 |
| commit | f467b28ac35add304442f30c2a05ef5d9df496e2 (patch) | |
| tree | fdecb0613a06c2351f19a9ec88f7817a52303ffe /src/test/txreconciliation_tests.cpp | |
| parent | 6cf47a8f44f96099a84e5c6e628e3499045e024d (diff) | |
| parent | bc862fad294fdb3e4232734497d0693a0da4d63a (diff) | |
| download | bitcoin-f467b28ac35add304442f30c2a05ef5d9df496e2.tar.xz | |
Merge bitcoin/bitcoin#27673: log: don't log total disk read time in ConnectTip bench
bc862fad294fdb3e4232734497d0693a0da4d63a ConnectTip: don't log total disk read time in bench (Sjors Provoost)
Pull request description:
The " Load block from disk" log introduced in #24216 incorrectly assumed `num_blocks_total` would be greater than 0. This is not guaranteed until the `ConnectBlock` call right below it.
The total and average metric is not very useful because it does not distinguish between blocks read from disk and those loaded from memory. So rather than fixing the divide by zero issue, we just drop the metric.
Fixes #27635
ACKs for top commit:
MarcoFalke:
lgtm ACK bc862fad294fdb3e4232734497d0693a0da4d63a 🐓
willcl-ark:
tACK bc862fad29
Tree-SHA512: ff52ff8a8a93f1c82071ca84c57ce5839e14271943393deac0aa5555d63383708777ed96e7226be6dd71b63ed07dc27bad1634ee848e88e4d0b95d511a8267e7
Diffstat (limited to 'src/test/txreconciliation_tests.cpp')
0 files changed, 0 insertions, 0 deletions