diff options
| author | merge-script <fanquake@gmail.com> | 2024-07-20 14:50:09 +0100 |
|---|---|---|
| committer | merge-script <fanquake@gmail.com> | 2024-07-20 14:50:09 +0100 |
| commit | 8d573611575c3fa66f08407aa9b02f91b29a94c3 (patch) | |
| tree | 4d36806021152db4d181ef30f0cdefb4cd38f01d /src/test/script_P2SH_tests.cpp | |
| parent | efeb39785aeee9130584b865d886c6b46e59f147 (diff) | |
| parent | 7703884ab19cd7ffddc5c52ba57dec82fbc8dc2b (diff) | |
| download | bitcoin-master.tar.xz | |
7703884ab19cd7ffddc5c52ba57dec82fbc8dc2b Fix MSVC warning C4273 "inconsistent dll linkage" (Hennadii Stepanov)
Pull request description:
Broken out of https://github.com/bitcoin/bitcoin/pull/30454.
When using CMake, the user can select the MSVC runtime library to be:
1) Statically-linked (with the corresponding `x64-windows-static` vcpkg triplet) or
2) Dynamically-linked (with the corresponding `x64-windows` vcpkg triplet)
In the latter case, the compiler emits the [C4273](https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4273) warning.
As the "Necessary on some platforms" comment does not apply to MSVC, skip the declaration for MSVC.
The MSVC build system in the master branch supports the statically-linked runtime only: https://github.com/bitcoin/bitcoin/blob/ed739d14b58b5e772a65b85bb421703963b06852/build_msvc/common.init.vcxproj.in#L65
ACKs for top commit:
sipa:
utACK 7703884ab19cd7ffddc5c52ba57dec82fbc8dc2b
sipsorcery:
utACK 7703884ab19cd7ffddc5c52ba57dec82fbc8dc2b.
theuni:
utACK 7703884ab19cd7ffddc5c52ba57dec82fbc8dc2b
Tree-SHA512: a42e1a0d48973217462e703c418f3e9ef9cb5236267c1bf32912aacaf68976cdd2b9229168523f7c2a99ee3f2fb1bf8add4f342796bdb1e4063ca026b761db51
Diffstat (limited to 'src/test/script_P2SH_tests.cpp')
0 files changed, 0 insertions, 0 deletions