diff options
| author | fanquake <fanquake@gmail.com> | 2023-06-13 09:28:26 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-06-13 09:43:53 +0100 |
| commit | 8de9bb7a5ab04669369e2bb59ea92a5c1a91a8d2 (patch) | |
| tree | 845b3801c870a61e25c2d84709525bbcca2a46eb /src/test/orphanage_tests.cpp | |
| parent | d80348ccb65601d19b4b408d442e0999b5a6cf98 (diff) | |
| parent | ee2417ed614d6a298f932ac068702ab2abee3cdf (diff) | |
Merge bitcoin/bitcoin#27864: test: fix intermittent failure in p2p_leak_tx.py
ee2417ed614d6a298f932ac068702ab2abee3cdf test: fix intermittent failure in p2p_leak_tx.py (Martin Zumsande)
Pull request description:
Fixes #27860
The problem was that the replacement tx `tx_b` would sometimes be sent out to the inbound peer after the `notfound`, so that threre would be an unexpected `tx` message and the test fails.
```
node0 2023-06-12T12:48:24.903204Z [msghand] [net.cpp:2856] [PushMessage] [net] sending notfound (73 bytes) peer=1
node0 2023-06-12T12:48:24.903916Z [msghand] [net.cpp:2856] [PushMessage] [net] sending tx (133 bytes) peer=1
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/test/functional/p2p_leak_tx.py", line 74, in test_notfound_on_replaced_tx
assert "tx" not in inbound_peer.last_message
```
Fix this by letting the peer wait for the initial broadcast of the replacement tx before continuing with the test.
ACKs for top commit:
MarcoFalke:
lgtm ACK ee2417ed614d6a298f932ac068702ab2abee3cdf
Tree-SHA512: ecc8fb44cac6097a949e4ee622f6f654f49851d7966359532ab3af4c5ed9d587bf08110820b473a616cde3ae6fc8d0da9bb3cee39347655a8c433e819d4d1065
Diffstat (limited to 'src/test/orphanage_tests.cpp')
0 files changed, 0 insertions, 0 deletions