diff options
| author | Ava Chow <github@achow101.com> | 2024-05-21 13:59:33 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-05-21 13:59:33 -0400 |
| commit | 6c13b1375f8fd810f46f5650e01a464ee63cfa46 (patch) | |
| tree | 405839a3fd932cead2ebecc7c5a212e05f923391 /src/test/net_tests.cpp | |
| parent | a786fd2041913d82ca90b561de309421bd24e41b (diff) | |
| parent | b3efb486732f3caf8b8a8e9d744e6d20ae4255ef (diff) | |
Merge bitcoin/bitcoin#29421: net: make the list of known message types a compile time constant
b3efb486732f3caf8b8a8e9d744e6d20ae4255ef protocol: make message types constexpr (Vasil Dimov)
2fa9de06c2c8583ee8e2434dc97014b26e218ab5 net: make the list of known message types a compile time constant (Vasil Dimov)
Pull request description:
Turn the `std::vector` to `std::array` because it is cheaper and allows us to have the number of the messages as a compile time constant: `ALL_NET_MESSAGE_TYPES.size()` which can be used in future code to build other `std::array`s with that size.
---
This change is part of https://github.com/bitcoin/bitcoin/pull/29418 but it makes sense on its own and would be good to have it, regardless of the fate of https://github.com/bitcoin/bitcoin/pull/29418. Also, if this is merged, that would reduce the size of https://github.com/bitcoin/bitcoin/pull/29418, thus the current standalone PR.
ACKs for top commit:
achow101:
ACK b3efb486732f3caf8b8a8e9d744e6d20ae4255ef
jonatack:
ACK b3efb486732f3caf8b8a8e9d744e6d20ae4255ef
maflcko:
utACK b3efb486732f3caf8b8a8e9d744e6d20ae4255ef 🎊
willcl-ark:
ACK b3efb486732f3caf8b8a8e9d744e6d20ae4255ef
Tree-SHA512: 6d3860c138c64514ebab13d97ea67893e2d346dfac30a48c3d9bc769a1970407375ea4170afdb522411ced306a14a9af4eede99e964d1fb1ea3efff5d5eb57af
Diffstat (limited to 'src/test/net_tests.cpp')
0 files changed, 0 insertions, 0 deletions