diff options
| author | fanquake <fanquake@gmail.com> | 2023-11-03 14:35:30 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-11-03 14:41:17 +0000 |
| commit | 5d9f45082bda426340dada89b03d0bee96dd2c42 (patch) | |
| tree | e84cdf038f48039a9d664c41289e75a3a4ed411d /src/test/net_peer_eviction_tests.cpp | |
| parent | f23ac10ca5a322e87664b58233dccc4cb74c0570 (diff) | |
| parent | b5a60abe8783852f5b31bc1e63b5836530410e65 (diff) | |
Merge bitcoin/bitcoin#28758: refactors for subpackage evaluation
b5a60abe8783852f5b31bc1e63b5836530410e65 MOVEONLY: CleanupTemporaryCoins into its own function (glozow)
10c0a8678cd28e7f0715e6cfa3e651903e4ad4aa [test util] CreateValidTransaction multi-in/out, configurable feerate, signal BIP125 (glozow)
6ff647a7e0d85040a6033047c5cf84f8f22b1c65 scripted-diff: rename CheckPackage to IsWellFormedPackage (glozow)
da9aceba217bbded6909f06144eaa1e1a4ebcb69 [refactor] move package checks into helper functions (glozow)
Pull request description:
This is part of #27463. It splits off the more trivial changes from #26711 for ease of review, as requested in https://github.com/bitcoin/bitcoin/pull/26711#issuecomment-1786392253.
- Split package sanitization in policy/packages.h into helper functions
- Add some tests for its quirks (https://github.com/bitcoin/bitcoin/pull/26711#discussion_r1340521597)
- Rename `CheckPackage` to `IsPackageWellFormed`
- Improve the `CreateValidTransaction` unit test utility to:
- Configure the target feerate and return the fee paid
- Signal BIP125 on transactions to enable RBF tests
- Allow the specification of multiple inputs and outputs
- Move `CleanupTemporaryCoins` into its own function to be reused later without duplication
ACKs for top commit:
dergoegge:
Code review ACK b5a60abe8783852f5b31bc1e63b5836530410e65
instagibbs:
ACK b5a60abe8783852f5b31bc1e63b5836530410e65
Tree-SHA512: 39d67a5f0041e381f0d0f802a98ccffbff11e44daa3a49611189d6306b03f18613d5ff16c618898d490c97a216753e99e0db231ff14d327f92c17ae4d269cfec
Diffstat (limited to 'src/test/net_peer_eviction_tests.cpp')
0 files changed, 0 insertions, 0 deletions