diff options
| author | fanquake <fanquake@gmail.com> | 2022-10-10 16:14:39 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2022-10-10 16:45:39 +0800 |
| commit | 9eaa5dbc81128ad81323b2cd81c81e286b4d14cb (patch) | |
| tree | d41db08d4b7cd9877022f49a711241546250b804 /src/test/mempool_tests.cpp | |
| parent | 9f44f2e32f641bb6c14e94293bb12f8b3b60efc9 (diff) | |
| parent | faa15527d7e0c7923ff9c0fad7bab4648705ed0f (diff) | |
Merge bitcoin/bitcoin#25073: test: Cleanup miner_tests
faa15527d7e0c7923ff9c0fad7bab4648705ed0f test: Use dedicated mempool in TestBasicMining (MacroFake)
fafab384a0a5f6d80195307b7bbeb00515da432b test: Use dedicated mempool in TestPackageSelection (MacroFake)
fa4055d79c7ea1d4c3b694e39cafa98a1c7ba8bb test: Use dedicated mempool in TestPrioritisedMining (MacroFake)
fa2921828511816d0420c567386e1da0391b3ad7 test: Pass mempool reference to AssemblerForTest (MacroFake)
Pull request description:
This cleans up the miner tests:
* Removes duplicate/redundant and thus confusing chainparams object.
* Uses a fresh mempool for each subtest instead of using the "global" one from the testing setup. This makes it easier to follow the tests in smaller scopes. Also it makes sure the mempool is truly cleared by reconstructing it. Finally, this removes calls to `clear`, see https://github.com/bitcoin/bitcoin/pull/19909
ACKs for top commit:
glozow:
utACK faa15527d7e0c7923ff9c0fad7bab4648705ed0f
Tree-SHA512: ced1260f6ab70fba74b0fac7ff4fc7adfddcd2f3bee785249d2a4a9055ac253eff9090edbda7a17e72a71a81b56ff708d5ff64e1f57ebc7b7747d6c88fec51e3
Diffstat (limited to 'src/test/mempool_tests.cpp')
0 files changed, 0 insertions, 0 deletions