aboutsummaryrefslogtreecommitdiff
path: root/src/test/key_io_tests.cpp
diff options
context:
space:
mode:
authorAurèle Oulès <aurele@oules.com>2022-07-26 11:12:53 +0200
committerAurèle Oulès <aurele@oules.com>2022-07-27 13:27:57 +0200
commit081b0e53e3adca7ea57d23e5fcd9db4b86415a72 (patch)
tree877f1eb2d246084e645f8cf5961d5541438a308b /src/test/key_io_tests.cpp
parent7f79746bf046d0028bb68f265804b9774dec2acb (diff)
downloadbitcoin-081b0e53e3adca7ea57d23e5fcd9db4b86415a72.tar.xz
refactor: Make const refs vars where applicable
This avoids initializing variables with the copy-constructor of a non-trivially copyable type.
Diffstat (limited to 'src/test/key_io_tests.cpp')
-rw-r--r--src/test/key_io_tests.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/test/key_io_tests.cpp b/src/test/key_io_tests.cpp
index e70b8b3dfd..1eac68de14 100644
--- a/src/test/key_io_tests.cpp
+++ b/src/test/key_io_tests.cpp
@@ -28,7 +28,7 @@ BOOST_AUTO_TEST_CASE(key_io_valid_parse)
SelectParams(CBaseChainParams::MAIN);
for (unsigned int idx = 0; idx < tests.size(); idx++) {
- UniValue test = tests[idx];
+ const UniValue& test = tests[idx];
std::string strTest = test.write();
if (test.size() < 3) { // Allow for extra stuff (useful for comments)
BOOST_ERROR("Bad test: " << strTest);
@@ -86,7 +86,7 @@ BOOST_AUTO_TEST_CASE(key_io_valid_gen)
UniValue tests = read_json(std::string(json_tests::key_io_valid, json_tests::key_io_valid + sizeof(json_tests::key_io_valid)));
for (unsigned int idx = 0; idx < tests.size(); idx++) {
- UniValue test = tests[idx];
+ const UniValue& test = tests[idx];
std::string strTest = test.write();
if (test.size() < 3) // Allow for extra stuff (useful for comments)
{
@@ -126,7 +126,7 @@ BOOST_AUTO_TEST_CASE(key_io_invalid)
CTxDestination destination;
for (unsigned int idx = 0; idx < tests.size(); idx++) {
- UniValue test = tests[idx];
+ const UniValue& test = tests[idx];
std::string strTest = test.write();
if (test.size() < 1) // Allow for extra stuff (useful for comments)
{