diff options
| author | Ava Chow <github@achow101.com> | 2024-01-31 16:30:12 -0500 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-01-31 16:36:31 -0500 |
| commit | 4b6687719768b6fd0812edc4cc4b6f9f91622dbc (patch) | |
| tree | 2aa70288c9a4840384536ad10a5d8324736133ba /src/test/fuzz | |
| parent | 6f7395b3ff21228183df190f3ed1bdc3049f39e2 (diff) | |
| parent | 9642aefb81a9c87227eccf9997380024247ed1fc (diff) | |
| download | bitcoin-4b6687719768b6fd0812edc4cc4b6f9f91622dbc.tar.xz | |
Merge bitcoin/bitcoin#29352: test: fix intermittent failure in p2p_v2_earlykeyresponse
9642aefb81a9c87227eccf9997380024247ed1fc test: fix intermittent failure in p2p_v2_earlykeyresponse (Martin Zumsande)
Pull request description:
The test fails intermittently, see https://cirrus-ci.com/task/6403578080788480?logs=ci#L3521 and https://github.com/bitcoin/bitcoin/pull/24748#issuecomment-1916996716.
I think it's because of a race between the python NetworkThread and the actual
test, which will both call `initiate_v2_handshake`. I could reproduce it by adding a sleep into `initiate_v2_handshake` after the line `self.sent_garbage = random.randbytes(garbage_len)`.
Fix this by waiting for the first `initiate_v2_handshake` to have finished before calling it a second time.
ACKs for top commit:
stratospher:
tested ACK 9642aef.
achow101:
ACK 9642aefb81a9c87227eccf9997380024247ed1fc
theStack:
Tested ACK 9642aefb81a9c87227eccf9997380024247ed1fc
Tree-SHA512: f728bbceaf816ddefeee4957494ccb608ad4fc912cb5cbf5f2acf09836df969c4e8fa2bb441aadb94fa39b3ffbb005d4132e7b6a5a98d80811810d8bd1d624e3
Diffstat (limited to 'src/test/fuzz')
0 files changed, 0 insertions, 0 deletions