diff options
author | MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> | 2023-12-07 11:01:06 +0100 |
---|---|---|
committer | MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> | 2023-12-07 12:05:21 +0100 |
commit | fa5989d514d246e56977c528b2dd2abe6dc8efcc (patch) | |
tree | fbdd82353d20069e70aa9c2bc3820a6b485d17c6 /src/test/blockchain_tests.cpp | |
parent | fa604eb6cfa7f70ce11c78c1060f0823884c745b (diff) | |
download | bitcoin-fa5989d514d246e56977c528b2dd2abe6dc8efcc.tar.xz |
refactor: rpc: Pass CBlockIndex by reference instead of pointer
All functions assume that the pointer is never null, so pass by
reference, to avoid accidental segfaults at runtime, or at least make
them more obvious.
Also, remove unused c-style casts in touched lines.
Also, add CHECK_NONFATAL checks, to turn segfault crashes into an
recoverable runtime error with debug information.
Diffstat (limited to 'src/test/blockchain_tests.cpp')
-rw-r--r-- | src/test/blockchain_tests.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/blockchain_tests.cpp b/src/test/blockchain_tests.cpp index b590467a43..be515a9eac 100644 --- a/src/test/blockchain_tests.cpp +++ b/src/test/blockchain_tests.cpp @@ -41,7 +41,7 @@ static void RejectDifficultyMismatch(double difficulty, double expected_difficul static void TestDifficulty(uint32_t nbits, double expected_difficulty) { CBlockIndex* block_index = CreateBlockIndexWithNbits(nbits); - double difficulty = GetDifficulty(block_index); + double difficulty = GetDifficulty(*block_index); delete block_index; RejectDifficultyMismatch(difficulty, expected_difficulty); |