diff options
| author | MeshCollider <dobsonsa68@gmail.com> | 2019-06-19 00:52:24 +1200 |
|---|---|---|
| committer | MeshCollider <dobsonsa68@gmail.com> | 2019-06-19 00:52:39 +1200 |
| commit | 22b6c4ed7562a23e4363e8f0fd889b92c7653d5f (patch) | |
| tree | 7a4247625d70353ca3fa50d6e9d2835a36bc7bc6 /src/serialize.h | |
| parent | 98958c81f5065a5de13699d46995d278ecb6709e (diff) | |
| parent | fa499b5f027f77c0bf13699852c8c06f78e27bef (diff) | |
| download | bitcoin-22b6c4ed7562a23e4363e8f0fd889b92c7653d5f.tar.xz | |
Merge #15899: rpc: Document iswitness flag and fix bug in converttopsbt
fa499b5f027f77c0bf13699852c8c06f78e27bef rpc: bugfix: Properly use iswitness in converttopsbt (MarcoFalke)
fa5c5cd141f0265a5693234690ac757b811157d8 rpc: Switch touched RPCs to IsValidNumArgs (MarcoFalke)
Pull request description:
When a serialized transaction has inputs, there is no risk in only trying to deserialize it with witness allowed. (This is how all transactions from p2p are deserialized.) In fact, it would avoid a common issue where a transaction with inputs can be deserialized in two ways:
* Fixes #12989
* Fixes #15872
* Fixes #15701
* Fixes #13738
* ...
When a serialized transaction has no inputs, there is no risk in only trying to deserialze it with witness disallowed. (A transaction without inputs can't have corresponding witness data)
ACKs for commit fa499b:
meshcollider:
utACK https://github.com/bitcoin/bitcoin/pull/15899/commits/fa499b5f027f77c0bf13699852c8c06f78e27bef
ryanofsky:
utACK fa499b5f027f77c0bf13699852c8c06f78e27bef. Changes since last review: consolidating commits and making iswitness documentation the same across methods.
PastaPastaPasta:
utACK fa499b5f027f77c0bf13699852c8c06f78e27bef
Tree-SHA512: a64423a3131f3f0222a40da557c8b590c9ff01b45bcd40796f77a1a64ae74c6680a6be9d01ece95c492dfbcc7e2810409d2c2b336c2894af00bb213972fc85c6
Diffstat (limited to 'src/serialize.h')
0 files changed, 0 insertions, 0 deletions