diff options
| author | Pieter Wuille <pieter.wuille@gmail.com> | 2013-03-29 00:43:31 +0100 |
|---|---|---|
| committer | Pieter Wuille <sipa@ulyssis.org> | 2013-04-04 14:45:45 +0200 |
| commit | cedaa714462871213472019545b8e862dacdac91 (patch) | |
| tree | 624e3d8ff65f5f2978abe5fa0c7274b8c6c41f47 /src/rpcnet.cpp | |
| parent | aaf47eac3abef5741b6c108fdc8a19cb46b773a2 (diff) | |
| download | bitcoin-cedaa714462871213472019545b8e862dacdac91.tar.xz | |
Drop release times for CNode
It seems there were two mechanisms for assessing whether a CNode
was still in use: a refcount and a release timestamp. The latter
seems to have been there for a long time, as a safety mechanism.
However, this timer also keeps CNode objects alive for far longer
than necessary after disconnects, potentially opening up a DoS
window.
This commit removes the timestamp-based mechanism, and replaces
it with an assert(nRefCount >= 0), to verify that the refcounting
is indeed correctly working.
Diffstat (limited to 'src/rpcnet.cpp')
| -rw-r--r-- | src/rpcnet.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/rpcnet.cpp b/src/rpcnet.cpp index 4db3be9319..e37b3009dd 100644 --- a/src/rpcnet.cpp +++ b/src/rpcnet.cpp @@ -55,7 +55,6 @@ Value getpeerinfo(const Array& params, bool fHelp) obj.push_back(Pair("version", stats.nVersion)); obj.push_back(Pair("subver", stats.strSubVer)); obj.push_back(Pair("inbound", stats.fInbound)); - obj.push_back(Pair("releasetime", (boost::int64_t)stats.nReleaseTime)); obj.push_back(Pair("startingheight", stats.nStartingHeight)); obj.push_back(Pair("banscore", stats.nMisbehavior)); |