diff options
| author | Ava Chow <github@achow101.com> | 2024-03-20 16:21:18 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-03-20 16:38:32 -0400 |
| commit | bf1b6383dbbfdd0c96a161d4693a48bf3a6b6150 (patch) | |
| tree | 52a3c31cc58fa81d009470627311d7ae994e9ac6 /src/qt | |
| parent | b50554babdddf452acaa51bac757736766c70e81 (diff) | |
| parent | f65b0f6401091e4a4ca4c9f4db1cf388f0336bad (diff) | |
Merge bitcoin/bitcoin#29671: index: avoid "failed to commit" errors on initialization
f65b0f6401091e4a4ca4c9f4db1cf388f0336bad index: Move last_locator_write_time and logging to end of threadsync loop (Fabian Jahr)
Pull request description:
In the index sync thread, when initializing an index for the first time, stop callng BaseIndex::Commit when m_best_block_index is null, to avoid a spurious "failed to commit" error from that function. This error started happening in commit https://github.com/bitcoin/bitcoin/commit/7878f97bf15b6e7c9b47d1c0d96419b97e1bdcbd from https://github.com/bitcoin/bitcoin/pull/25494 and was reported by pstratem in https://github.com/bitcoin/bitcoin/pull/26903 with an alternate fix.
ACKs for top commit:
achow101:
ACK f65b0f6401091e4a4ca4c9f4db1cf388f0336bad
ryanofsky:
Code review ACK f65b0f6401091e4a4ca4c9f4db1cf388f0336bad. Just moved log "Syncing" log line since last commit to avoid having to call now() twice.
furszy:
ACK f65b0f6401091e4a4ca4c9f4db1cf388f0336bad
TheCharlatan:
ACK f65b0f6401091e4a4ca4c9f4db1cf388f0336bad
Tree-SHA512: afa8f05786318d36346d167ff53ea0b3bc8abdb0ad04465d199dc3eb91e9f837369e24fcb7e24b5757b02d698ec504e61da6ac365eaf006c874fc07a424a7e20
Diffstat (limited to 'src/qt')
0 files changed, 0 insertions, 0 deletions