diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-10-19 09:22:12 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-10-19 09:22:22 +0200 |
| commit | bbe26553097557e890aa1632ac2d83a7a98ac56b (patch) | |
| tree | 3d35e7add4306fc9b07125219369374479138c20 /src/qt | |
| parent | c102a558e18b1d0821a25fd7253a36003048186d (diff) | |
| parent | b147322a7a387423164de5a7d91a33eacad51689 (diff) | |
| download | bitcoin-bbe26553097557e890aa1632ac2d83a7a98ac56b.tar.xz | |
Merge bitcoin/bitcoin#26142: Use `PACKAGE_NAME` in messages rather than hardcoding "Bitcoin Core"
b147322a7a387423164de5a7d91a33eacad51689 Use `PACKAGE_NAME` in messages rather than hardcoding "Bitcoin Core" (Hennadii Stepanov)
Pull request description:
Usually, we do not hardcode "Bitcoin Core" in the user-faced messages.
See:
- bitcoin/bitcoin#18646
- bitcoin/bitcoin#19282
Also grammar has been improved -- singular instead of plural.
ACKs for top commit:
jarolrod:
ACK b147322a7a387423164de5a7d91a33eacad51689
Tree-SHA512: b135c18703dfdd7b63d4cb27d1ac48f6a9dbf69382142ae381f33bf561cbf57477a11d1c73263aa834f705206d7dd5716df2523d38ed0d4cfec8babc38bb017a
Diffstat (limited to 'src/qt')
| -rw-r--r-- | src/qt/forms/optionsdialog.ui | 2 | ||||
| -rw-r--r-- | src/qt/optionsdialog.cpp | 4 |
2 files changed, 4 insertions, 2 deletions
diff --git a/src/qt/forms/optionsdialog.ui b/src/qt/forms/optionsdialog.ui index 582f02132a..6be47e94fe 100644 --- a/src/qt/forms/optionsdialog.ui +++ b/src/qt/forms/optionsdialog.ui @@ -286,7 +286,7 @@ <item> <widget class="QLineEdit" name="externalSignerPath"> <property name="toolTip"> - <string>Full path to a Bitcoin Core compatible script (e.g. C:\Downloads\hwi.exe or /Users/you/Downloads/hwi.py). Beware: malware can steal your coins!</string> + <string>Full path to a %1 compatible script (e.g. C:\Downloads\hwi.exe or /Users/you/Downloads/hwi.py). Beware: malware can steal your coins!</string> </property> </widget> </item> diff --git a/src/qt/optionsdialog.cpp b/src/qt/optionsdialog.cpp index 2b6711ca40..7c91eac37e 100644 --- a/src/qt/optionsdialog.cpp +++ b/src/qt/optionsdialog.cpp @@ -91,7 +91,9 @@ OptionsDialog::OptionsDialog(QWidget *parent, bool enableWallet) : ui->thirdPartyTxUrls->setVisible(false); } -#ifndef ENABLE_EXTERNAL_SIGNER +#ifdef ENABLE_EXTERNAL_SIGNER + ui->externalSignerPath->setToolTip(ui->externalSignerPath->toolTip().arg(PACKAGE_NAME)); +#else //: "External signing" means using devices such as hardware wallets. ui->externalSignerPath->setToolTip(tr("Compiled without external signing support (required for external signing)")); ui->externalSignerPath->setEnabled(false); |