diff options
| author | fanquake <fanquake@gmail.com> | 2024-02-07 15:07:50 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2024-02-07 15:08:02 +0000 |
| commit | 6737331c4ccc6da578bb44c809cc4e18f017ba51 (patch) | |
| tree | 4e3d29371595066b9d0afc9c3a5d7ef07cabdc09 /src/qt/walletmodeltransaction.cpp | |
| parent | 5b8990a1f3c49b0b02b7383c69e95320acbda13e (diff) | |
| parent | facafa90f7a1eee452f9baf8a1b65a2edac0982b (diff) | |
| download | bitcoin-6737331c4ccc6da578bb44c809cc4e18f017ba51.tar.xz | |
Merge bitcoin/bitcoin#29363: test: Fix CPartialMerkleTree.nTransactions signedness
facafa90f7a1eee452f9baf8a1b65a2edac0982b test: Fix CPartialMerkleTree.nTransactions signedness (MarcoFalke)
Pull request description:
It is unsigned in Bitcoin Core, so the tests should match it:
https://github.com/bitcoin/bitcoin/blob/aa9231fafe45513134ec8953a217cda07446fae8/src/merkleblock.h#L59
Large positive values, or "negative" values, are rejected anyway, but it still seems fine to fix this.
The bug was introduced when the code was written in d280617bf569f84457eaea546541dc74c67cd1e4.
(Lowercase `i` means signed, see https://docs.python.org/3/library/struct.html#format-characters)
ACKs for top commit:
theStack:
LGTM ACK facafa90f7a1eee452f9baf8a1b65a2edac0982b
Empact:
ACK facafa90f7a1eee452f9baf8a1b65a2edac0982b
Tree-SHA512: 35ac11bb5382dffe132bfae6097efc343ef6c06b1b4b1545130ca27b228ca6894679004862fee921b095172abaddbef5972c24d9bc195ce970f35643bd4a0f09
Diffstat (limited to 'src/qt/walletmodeltransaction.cpp')
0 files changed, 0 insertions, 0 deletions