diff options
| author | practicalswift <practicalswift@users.noreply.github.com> | 2017-06-01 16:13:35 +0200 |
|---|---|---|
| committer | practicalswift <practicalswift@users.noreply.github.com> | 2017-09-22 14:59:27 +0200 |
| commit | 9ad6746ccd6dc31141fd0144686b641e31bf626b (patch) | |
| tree | a5f2a33bef9eae6fde623ba8fd9233f1bb9942a4 /src/qt/walletmodel.cpp | |
| parent | 98212745c8acb5cc4e688bbb3979bfd46b25f98a (diff) | |
| download | bitcoin-9ad6746ccd6dc31141fd0144686b641e31bf626b.tar.xz | |
Use static_cast instead of C-style casts for non-fundamental types
A C-style cast is equivalent to try casting in the following order:
1. const_cast(...)
2. static_cast(...)
3. const_cast(static_cast(...))
4. reinterpret_cast(...)
5. const_cast(reinterpret_cast(...))
By using static_cast<T>(...) explicitly we avoid the possibility
of an unintentional and dangerous reinterpret_cast. Furthermore
static_cast<T>(...) allows for easier grepping of casts.
Diffstat (limited to 'src/qt/walletmodel.cpp')
| -rw-r--r-- | src/qt/walletmodel.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/qt/walletmodel.cpp b/src/qt/walletmodel.cpp index 53b1c2967c..f5ea65db72 100644 --- a/src/qt/walletmodel.cpp +++ b/src/qt/walletmodel.cpp @@ -701,7 +701,7 @@ bool WalletModel::bumpFee(uint256 hash) questionString.append("</td></tr></table>"); SendConfirmationDialog confirmationDialog(tr("Confirm fee bump"), questionString); confirmationDialog.exec(); - QMessageBox::StandardButton retval = (QMessageBox::StandardButton)confirmationDialog.result(); + QMessageBox::StandardButton retval = static_cast<QMessageBox::StandardButton>(confirmationDialog.result()); // cancel sign&broadcast if users doesn't want to bump the fee if (retval != QMessageBox::Yes) { |