diff options
author | John Moffett <john.moff@gmail.com> | 2023-01-26 10:19:11 -0500 |
---|---|---|
committer | John Moffett <john.moff@gmail.com> | 2023-01-26 14:56:12 -0500 |
commit | 08209c039ff4ca5be4982da7a2ab7a624117ce1a (patch) | |
tree | 7e61850a3136f74414397e23090deea0070830fd /src/qt/transactionfilterproxy.h | |
parent | ab98673f058853e00c310afad57925f54c1ecfae (diff) | |
download | bitcoin-08209c039ff4ca5be4982da7a2ab7a624117ce1a.tar.xz |
Correctly limit overview transaction list
The way that the main overview page limits the number
of transactions displayed (currently 5) is not
an appropriate use of Qt. If it's run with a DEBUG
build of Qt, it'll result in a segfault in certain
relatively common situations. Instead of artificially
limiting the rowCount() in the subclassed proxy
filter, we hide/unhide the rows in the displaying
QListView upon any changes in the sorted proxy filter.
Diffstat (limited to 'src/qt/transactionfilterproxy.h')
-rw-r--r-- | src/qt/transactionfilterproxy.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/qt/transactionfilterproxy.h b/src/qt/transactionfilterproxy.h index 8e5f72d764..73c4f21426 100644 --- a/src/qt/transactionfilterproxy.h +++ b/src/qt/transactionfilterproxy.h @@ -42,14 +42,9 @@ public: void setMinAmount(const CAmount& minimum); void setWatchOnlyFilter(WatchOnlyFilter filter); - /** Set maximum number of rows returned, -1 if unlimited. */ - void setLimit(int limit); - /** Set whether to show conflicted transactions. */ void setShowInactive(bool showInactive); - int rowCount(const QModelIndex &parent = QModelIndex()) const override; - protected: bool filterAcceptsRow(int source_row, const QModelIndex & source_parent) const override; @@ -60,7 +55,6 @@ private: quint32 typeFilter; WatchOnlyFilter watchOnlyFilter{WatchOnlyFilter_All}; CAmount minAmount{0}; - int limitRows{-1}; bool showInactive{true}; }; |