diff options
author | MarcoFalke <falke.marco@gmail.com> | 2020-07-13 10:34:21 +0200 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2020-07-13 10:34:27 +0200 |
commit | d52bfc49161721fd55b9312549b3da674da387fe (patch) | |
tree | 74b6179dd0a2a79faae68298fe685ce82ac18ace /src/qt/test/wallettests.cpp | |
parent | 631284f09a18a998a150e063fe8f29aa47e71e0b (diff) | |
parent | d0cc1f6df740e03ca0213a3754c3277b01ae2c05 (diff) | |
download | bitcoin-d52bfc49161721fd55b9312549b3da674da387fe.tar.xz |
Merge bitcoin-core/gui#30: Disable the main window toolbar when the modal overlay is shown
d0cc1f6df740e03ca0213a3754c3277b01ae2c05 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd2083d579b14b0b718aa36796f2bcf679600 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)
Pull request description:
Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.
Fixes #22.
---
On master (ca055885c631de8ac0ffe24be6b02835dbcc039d):
![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)
With this PR:
![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)
ACKs for top commit:
harding:
Tested ACK d0cc1f6df740e03ca0213a3754c3277b01ae2c05. Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement. I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
jonatack:
ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
LarryRuane:
ACK d0cc1f6df740e03ca0213a3754c3277b01ae2c05 tested on Ubuntu 18.04.4 LTS
Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
Diffstat (limited to 'src/qt/test/wallettests.cpp')
0 files changed, 0 insertions, 0 deletions