diff options
| author | Sjors Provoost <sjors@sprovoost.nl> | 2022-02-21 13:32:21 +0100 |
|---|---|---|
| committer | Sjors Provoost <sjors@sprovoost.nl> | 2022-03-16 10:28:39 +0100 |
| commit | 2efdfb88aab6496dcf2b98e0de30635bc6bade85 (patch) | |
| tree | 89428496f465219470d7dfe4ca43f4fc9686278f /src/qt/sendcoinsdialog.h | |
| parent | 4b5a6cd14967b8ec3cb525e4cb18628de6c15091 (diff) | |
| download | bitcoin-2efdfb88aab6496dcf2b98e0de30635bc6bade85.tar.xz | |
gui: restore Send for external signer
Before this change the send confirmation dialog would keep the Send option disabled. The Create Unsigned choice would actually send. This is potentially confusing.
With this change the Create Unsigned button will not attempt to sign and always produce a PSBT. The Send button will attempt to sign, and only return a PSBT if more signatures are needed.
When using an external signer, the Create Unsigned option only appears when PSBT controls are enabled in the wallet settings.
This commit maintains the pre-existing behavior of filling the PSBT (without signing) even when not using an external signer.
Closes #551
Co-authored-by: Jon Atack <jon@atack.com>
Diffstat (limited to 'src/qt/sendcoinsdialog.h')
| -rw-r--r-- | src/qt/sendcoinsdialog.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/qt/sendcoinsdialog.h b/src/qt/sendcoinsdialog.h index 87f3fbc14c..400503d0c0 100644 --- a/src/qt/sendcoinsdialog.h +++ b/src/qt/sendcoinsdialog.h @@ -128,6 +128,8 @@ class SendConfirmationDialog : public QMessageBox public: SendConfirmationDialog(const QString& title, const QString& text, const QString& informative_text = "", const QString& detailed_text = "", int secDelay = SEND_CONFIRM_DELAY, bool enable_send = true, bool always_show_unsigned = true, QWidget* parent = nullptr); + /* Returns QMessageBox::Cancel, QMessageBox::Yes when "Send" is + clicked and QMessageBox::Save when "Create Unsigned" is clicked. */ int exec() override; private Q_SLOTS: |