diff options
| author | fanquake <fanquake@gmail.com> | 2023-09-16 12:08:07 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-09-16 12:15:16 +0100 |
| commit | 372e7b6510d14976dbc25f3d67f3e43247402385 (patch) | |
| tree | 632a05c8d40d2a62deeab6369001c1d3dd0a8f7d /src/qt/rpcconsole.h | |
| parent | 5c7cdda992442d8b1dce5bc4b239e8645c507a3c (diff) | |
| parent | 3f4e1bb9ae5ee43da9503da37b9894037d613c6d (diff) | |
| download | bitcoin-372e7b6510d14976dbc25f3d67f3e43247402385.tar.xz | |
Merge bitcoin/bitcoin#28489: tests: fix incorrect assumption in v2transport_test
3f4e1bb9ae5ee43da9503da37b9894037d613c6d tests: fix incorrect assumption in v2transport_test (Pieter Wuille)
Pull request description:
One part of the current `v2transport_test` introduced in #28196 assumes that if a bit gets modified in a message, failure should instantly be detected after sending that message. This is not correct in case the length descriptor is modified, as that may cause the receiver to need more data first. Fix this by sending more messages until failure actually occurs.
Discovered in https://github.com/bitcoin/bitcoin/pull/27495#issuecomment-1719934041.
ACKs for top commit:
theStack:
ACK 3f4e1bb9ae5ee43da9503da37b9894037d613c6d
Tree-SHA512: faa90bf91996cbaaef62d764e746cb222eaf6796316b0d0e13709e528750b7c0ef09172f7fecfe814dbb8c136c5259f65ca1ac79318e6768a0bfc4e626a63249
Diffstat (limited to 'src/qt/rpcconsole.h')
0 files changed, 0 insertions, 0 deletions