diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2022-02-21 08:16:29 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2022-02-21 08:16:31 +0100 |
| commit | cf22191fd8cf7fae22e561e14b3a68e49e39b15c (patch) | |
| tree | 758e35786991ab0318b136db4d66afd695a686c6 /src/qt/rpcconsole.cpp | |
| parent | 4acf2332d49dd9ef3fcde2480e2342134b53d688 (diff) | |
| parent | 6981de4435573ad44ee53fd5efc10894866ed2f9 (diff) | |
Merge bitcoin/bitcoin#24072: doc: fix wording of alertnotify to match behaviour
6981de4435573ad44ee53fd5efc10894866ed2f9 doc: fix wording of alertnotify (willcl-ark)
Pull request description:
The documentation of the `alertnotify` startup option no longer matches the implementation.
Currently the alert is only triggered by `DoWarning` (as part of `CChainstate::UpdateTip` when blocks containing unknown versionbits are detected on the network, indicating that there may be an upcoming softfork which you don't know about), but not when we see a "really long fork":
https://github.com/bitcoin/bitcoin/blob/2825c41a6121524bc647002cbb4258cbf701a14b/src/validation.cpp#L2418-L2433
I think it would be desirable in a follow-up PR to implement the logic to alert on a (really) long fork, but not to alert for "partition detection" (abnormally slow/fast blocks). `PartitionChecker` code was removed in ab8be98fdb25b678a8cd7e89adf06d1b1f6bdd62
ACKs for top commit:
josibake:
ACK https://github.com/bitcoin/bitcoin/pull/24072/commits/6981de4435573ad44ee53fd5efc10894866ed2f9
achow101:
ACK 6981de4435573ad44ee53fd5efc10894866ed2f9
Tree-SHA512: ea124f53ca1db803ba93d649f4bc983484c47fb5fe7fa61a8eb32fcbc7425f67d8578e66a6ba70202e13868fe8add0103306dede3b1edd1d3261ffb9c1042b87
Diffstat (limited to 'src/qt/rpcconsole.cpp')
0 files changed, 0 insertions, 0 deletions