diff options
| author | merge-script <fanquake@gmail.com> | 2024-08-02 14:02:04 +0100 |
|---|---|---|
| committer | merge-script <fanquake@gmail.com> | 2024-08-02 14:02:04 +0100 |
| commit | df241970a3a3e7e24c001c399435d1baf3b8a2ae (patch) | |
| tree | c0596c587777e4a2746e5a15f98c3d31ff9e99e3 /src/qt/forms/debugwindow.ui | |
| parent | 9c6c667bc2bcd34270241db52411369c46c9f2f0 (diff) | |
| parent | fa46a1b74bd35371036af17b2df2036dbc993ce1 (diff) | |
| download | bitcoin-df241970a3a3e7e24c001c399435d1baf3b8a2ae.tar.xz | |
Merge bitcoin/bitcoin#30554: test: Avoid CScript() as default function argument
fa46a1b74bd35371036af17b2df2036dbc993ce1 test: Avoid CScript() as default function argument (MarcoFalke)
fadf621825fdbf5fd131da14419bb19bb81e5801 test: Make leaf_script mandatory when scriptpath is set in TaprootSignatureMsg (MarcoFalke)
Pull request description:
Unlike other function calls in default arguments, CScript should not cause any issues in the tests, because they are const.
However, this change allows to enable the "function-call-in-default-argument (B008)" lint rule, which will help to catch severe test bugs, such as https://github.com/bitcoin/bitcoin/issues/30543#issuecomment-2259260024 .
The lint rule will be enabled in a follow-up, when all violations are fixed.
ACKs for top commit:
instagibbs:
utACK fa46a1b74bd35371036af17b2df2036dbc993ce1
theStack:
lgtm ACK fa46a1b74bd35371036af17b2df2036dbc993ce1
ismaelsadeeq:
Tested ACK fa46a1b74bd35371036af17b2df2036dbc993ce1
Tree-SHA512: bc68b15121d50ead0fc70ad772360a7829908aedeaff8426efcb8a67f33117f67d26b4f5da94fa735dd8de9c9ff65fc10a29323f1b12f238b75486fa7cc32a89
Diffstat (limited to 'src/qt/forms/debugwindow.ui')
0 files changed, 0 insertions, 0 deletions