diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-07-16 08:07:12 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-07-16 08:07:25 +0200 |
| commit | affed844babde7ea3647178f9e8c6088de1bb7a2 (patch) | |
| tree | 3bfc7b255b229f139aeb68e6e8282f1d160dede9 /src/qt/bitcoingui.cpp | |
| parent | 3864219d4074d289799634378d85cccbcc2e6e56 (diff) | |
| parent | 0c8461a88ed66a1f70559fc96646708949b17e4b (diff) | |
Merge #19174: refactor: replace CConnman pointers by references in net_processing.cpp
0c8461a88ed66a1f70559fc96646708949b17e4b refactor: replace CConnman pointers by references in net_processing.cpp (Sebastian Falbesoner)
Pull request description:
This is a follow-up to the recently merged PR https://github.com/bitcoin/bitcoin/pull/19053, replacing ~~two more types of~~ one more type of pointer (CConnman) by references to increase the code quality -- pointers should either check for `nullptr` or be replaced by references, and the latter strategy seems to be more reasonable.
Again, to keep the review burden managable, the changes are kept simple,
* only tackling `CConnman*` ~~and `BanMan*`~~ pointers
* only within the net_processing module, i.e. no changes that would need adaption in other modules
* keeping the names of the variables as they are
ACKs for top commit:
jnewbery:
utACK 0c8461a88ed66a1f70559fc96646708949b17e4b
MarcoFalke:
ACK 0c8461a88ed66a1f70559fc96646708949b17e4b 🕧
Tree-SHA512: 79dc05144bcfb5e0bbc62180285aadcc6199f044fa3016c0f54f7b7f45037415260970037bd63b18fafefb8aef448549dae14b780bafb540fa2373f493a17f71
Diffstat (limited to 'src/qt/bitcoingui.cpp')
0 files changed, 0 insertions, 0 deletions