diff options
author | Andrew Chow <achow101-github@achow101.com> | 2022-07-14 14:44:44 -0400 |
---|---|---|
committer | Andrew Chow <achow101-github@achow101.com> | 2022-07-14 14:54:19 -0400 |
commit | 85b601e04363664eae1b4b802cd8dde942761939 (patch) | |
tree | 9cd5c5410e75c82d98e8bac1e315dcc8fcf12041 /src/qt/bitcoingui.cpp | |
parent | 02ede4f1fde9b5aa3ff370d523f9c9858c98905c (diff) | |
parent | ffc79b8e492c6dd1352e528fd82e45d8d25eaa04 (diff) | |
download | bitcoin-85b601e04363664eae1b4b802cd8dde942761939.tar.xz |
Merge bitcoin/bitcoin#24148: Miniscript support in Output Descriptors
ffc79b8e492c6dd1352e528fd82e45d8d25eaa04 qa: functional test Miniscript watchonly support (Antoine Poinsot)
bfb036756ad6e187fd6d3abfefe5804bb54a5c71 Miniscript support in output descriptors (Antoine Poinsot)
4a082887bee76a96deada5dbd7f991c23b301c54 qa: better error reporting on descriptor parsing error (Antoine Poinsot)
d25d58bf5f301d3bb8683bd67c8847a4957d8e97 miniscript: add a helper to find the first insane sub with no child (Antoine Poinsot)
c38c7c5817b7e73cf0f788855c4aba59c287b0ad miniscript: don't check for top level validity at parsing time (Antoine Poinsot)
Pull request description:
This adds Miniscript support for Output Descriptors without any signing logic (yet). See the OP of #24147 for a description of Miniscript and a rationale of having it in Bitcoin Core.
On its own, this PR adds "watchonly" support for Miniscript descriptors in the descriptor wallet. A follow-up adds signing support.
A minified corpus of Miniscript Descriptors for the `descriptor_parse` fuzz target is available at https://github.com/bitcoin-core/qa-assets/pull/92.
The Miniscript descriptors used in the unit tests here and in #24149 were cross-tested against the Rust implementation at https://github.com/rust-bitcoin/rust-miniscript.
This PR contains code and insights from Pieter Wuille.
ACKs for top commit:
Sjors:
re-utACK ffc79b8e492c6dd1352e528fd82e45d8d25eaa04
achow101:
ACK ffc79b8e492c6dd1352e528fd82e45d8d25eaa04
w0xlt:
reACK https://github.com/bitcoin/bitcoin/pull/24148/commits/ffc79b8e492c6dd1352e528fd82e45d8d25eaa04
Tree-SHA512: 02d919d38bb626d3c557eca3680ce71117739fa161b7a92cfdb6c9c432ed88870b1ed127ba24248574c40c7428217d7e9bdd986fd8cd7c51fae8c776e1271fb9
Diffstat (limited to 'src/qt/bitcoingui.cpp')
0 files changed, 0 insertions, 0 deletions