diff options
| author | fanquake <fanquake@gmail.com> | 2024-02-29 16:07:50 -0500 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2024-02-29 16:14:41 -0500 |
| commit | dfc35c99340da3236e2841b348580f0e881762ce (patch) | |
| tree | ad823ecdd28108fba4f032f83c61f949875e04fc /src/qt/README.md | |
| parent | be5399e7858da853e9417c28327b9c3478eb7238 (diff) | |
| parent | f8a06f7a02be83e9b76a1b31f1b66a965dbedfce (diff) | |
Merge bitcoin/bitcoin#29407: build: remove confusing and inconsistent disable-asm option
f8a06f7a02be83e9b76a1b31f1b66a965dbedfce doc: remove references to disable-asm option now that it's gone (Cory Fields)
376f0f6d0798c10f09266d609afea3ada1b99f9b build: remove confusing and inconsistent disable-asm option (Cory Fields)
Pull request description:
1. It didn't actually disable asm usage in our code. Regardless of the setting, asm is used in random.cpp and support/cleanse.cpp.
2. The value wasn't forwarded to libsecp as a user might have reasonably expected.
3. We now have the DISABLE_OPTIMIZED_SHA256 define which is what disable-asm actually did in practice.
If there is any desire, we can hook DISABLE_OPTIMIZED_SHA256 up to a new configure option that actually does what it says.
Additionally, this is one of the last (THE last?) remaining uses of autoconf defines in our crypto code. As such it seems like low-hanging fruit.
ACKs for top commit:
fanquake:
ACK f8a06f7a02be83e9b76a1b31f1b66a965dbedfce
Tree-SHA512: 4a99c2130225acbe9dc7399ed572a04ca155cbfa3eef8178a632ba533017d264691e6482cceb1d8f9c5d768619d99a2466dea4b82b27b18b872bceae91b92fbb
Diffstat (limited to 'src/qt/README.md')
0 files changed, 0 insertions, 0 deletions