diff options
| author | Gloria Zhao <gloriajzhao@gmail.com> | 2024-01-03 11:16:48 +0000 |
|---|---|---|
| committer | Gloria Zhao <gloriajzhao@gmail.com> | 2024-01-03 11:23:27 +0000 |
| commit | 65c05db660b2ca1d0076b0d8573a6760b3228068 (patch) | |
| tree | c6540c220754005ee66f2c7338237a2c29346fa9 /src/policy | |
| parent | c3038bf95a4b9926001abb8a172f3d734f8e17ba (diff) | |
| parent | b1318dcc56a0181783ee7ddbd388ae878a0efc52 (diff) | |
| download | bitcoin-65c05db660b2ca1d0076b0d8573a6760b3228068.tar.xz | |
Merge bitcoin/bitcoin#29013: test: doc: follow-up #28368
b1318dcc56a0181783ee7ddbd388ae878a0efc52 test: change `m_submitted_in_package` input to fuzz data provider boolean (ismaelsadeeq)
5615e16b705d74bf6ebb7c39523844f97a41cb6f tx fees: update `m_from_disconnected_block` to `m_mempool_limit_bypassed` (ismaelsadeeq)
fcd429664818f14cace580513e7e6159335b5416 doc: fix typo and update incorrect comment (ismaelsadeeq)
562664d26374331d291b97e2e2f7fca1f0fd467b test: wait for fee estimator to catch up before estimating fees (ismaelsadeeq)
Pull request description:
This is a simple PR that does two things
1. Fixes #29000 by waiting for the fee estimator to catch up after `removeForBlock` calls before calling `estimateFee` in the `BlockPolicyEstimates` unit test.
2. Addressed some outstanding review comments from #28368
- Updated `NewMempoolTransactionInfo::m_from_disconnected_block` to `NewMempoolTransactionInfo::m_mempool_limit_bypassed` which now correctly indicates what the boolean does.
- Changed input of `processTransaction`'s tx_info `m_submitted_in_package` input from false to fuzz data provider boolean.
- Fixed some typos, and update incorrect comment
ACKs for top commit:
martinus:
re-ACK b1318dcc56a0181783ee7ddbd388ae878a0efc52
glozow:
utACK b1318dcc56a0181783ee7ddbd388ae878a0efc52
Tree-SHA512: 45268729bc044da4748fe004524e0df696d2ec92c5bd053db9aad6e15675f3838429b2a7b9061a6b694be4dc319d1782a876b44df506ddd439d62ad07252d0e1
Diffstat (limited to 'src/policy')
| -rw-r--r-- | src/policy/fees.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/policy/fees.cpp b/src/policy/fees.cpp index 74c688060d..5440548636 100644 --- a/src/policy/fees.cpp +++ b/src/policy/fees.cpp @@ -612,7 +612,7 @@ void CBlockPolicyEstimator::processTransaction(const NewMempoolTransactionInfo& // - the node is not behind // - the transaction is not dependent on any other transactions in the mempool // - it's not part of a package. - const bool validForFeeEstimation = !tx.m_from_disconnected_block && !tx.m_submitted_in_package && tx.m_chainstate_is_current && tx.m_has_no_mempool_parents; + const bool validForFeeEstimation = !tx.m_mempool_limit_bypassed && !tx.m_submitted_in_package && tx.m_chainstate_is_current && tx.m_has_no_mempool_parents; // Only want to be updating estimates when our blockchain is synced, // otherwise we'll miscalculate how many blocks its taking to get included. |