diff options
| author | Ava Chow <github@achow101.com> | 2025-01-06 18:52:59 -0500 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2025-01-06 18:52:59 -0500 |
| commit | 433412fd8478923dfdb20044f74c5d1e19fa8dd8 (patch) | |
| tree | 50bee49eb5d573d88e342c3d95c226803fd6bf32 /src/policy | |
| parent | c506f2cee7b8398e5e34b5e881daf88725357a90 (diff) | |
| parent | 3e0a992a3f0f2b15b7be5049dc4f3134b4b0bc40 (diff) | |
3e0a992a3f0f2b15b7be5049dc4f3134b4b0bc40 doc: Clarify comments about endianness after #30526 (Ryan Ofsky)
Pull request description:
This is a documentation-only change following up on suggestions made in the #30526 review.
Motivation for this change is that I was recently reviewing #31583, which reminded me how confusing the arithmetic blob code was and made me want to write better comments.
ACKs for top commit:
achow101:
ACK 3e0a992a3f0f2b15b7be5049dc4f3134b4b0bc40
TheCharlatan:
ACK 3e0a992a3f0f2b15b7be5049dc4f3134b4b0bc40
Sjors:
ACK 3e0a992a3f0f2b15b7be5049dc4f3134b4b0bc40
BrandonOdiwuor:
LGTM ACK 3e0a992a3f0f2b15b7be5049dc4f3134b4b0bc40
Tree-SHA512: 90d5582a25a51fc406d83ca6b8c4e5e4d3aee828a0497f4b226b2024ff89e29b9b50d0ae8ddeac6abf2757fe78548d58cf3dd54df4b6d623f634a2106048091d
Diffstat (limited to 'src/policy')
| -rw-r--r-- | src/policy/packages.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/policy/packages.h b/src/policy/packages.h index 3050320122..4b2350edac 100644 --- a/src/policy/packages.h +++ b/src/policy/packages.h @@ -89,8 +89,9 @@ bool IsChildWithParents(const Package& package); */ bool IsChildWithParentsTree(const Package& package); -/** Get the hash of these transactions' wtxids, concatenated in lexicographical order (treating the - * wtxids as little endian encoded uint256, smallest to largest). */ +/** Get the hash of the concatenated wtxids of transactions, with wtxids + * treated as a little-endian numbers and sorted in ascending numeric order. + */ uint256 GetPackageHash(const std::vector<CTransactionRef>& transactions); #endif // BITCOIN_POLICY_PACKAGES_H |