diff options
| author | ismaelsadeeq <ask4ismailsadiq@gmail.com> | 2023-11-03 11:01:52 +0100 |
|---|---|---|
| committer | ismaelsadeeq <ask4ismailsadiq@gmail.com> | 2023-11-22 11:48:21 +0100 |
| commit | a0e3eb7549d2ba4dd3af12b9ce65e29158f59078 (patch) | |
| tree | 1e50981b85f12b1b354533773750657a299b566d /src/noui.cpp | |
| parent | 640b45053020cbbd0af4f4b53ed1b742b6232fb2 (diff) | |
tx fees, policy: bugfix: move `removeTx` into reason != `BLOCK` condition
If the removal reason of a transaction is BLOCK, then the `removeTx`
boolean argument should be true.
Before this PR, `CBlockPolicyEstimator` have to complete updating the fee stats
before the mempool clears that's why having removeTx call outside reason!= `BLOCK`
in `addUnchecked` was not a bug.
But in a case where the `CBlockPolicyEstimator` update is asynchronous, the mempool might
clear before we update the `CBlockPolicyEstimator` fee stats.
Transactions that are removed for `BLOCK` reasons will also be incorrectly removed from
`CBlockPolicyEstimator` stats as failures.
Diffstat (limited to 'src/noui.cpp')
0 files changed, 0 insertions, 0 deletions