diff options
| author | glozow <gloriajzhao@gmail.com> | 2024-01-30 12:03:10 +0000 |
|---|---|---|
| committer | glozow <gloriajzhao@gmail.com> | 2024-01-30 12:06:18 +0000 |
| commit | 700576649269d6e7d730b525950bc8f6cdf9a927 (patch) | |
| tree | f08aade4b117b1b94fd61c962c520c08133e5427 /src/node | |
| parent | 78c06a38c41cba8e8c5463ee05e38aa7c12038e1 (diff) | |
| parent | 9819db4ccaa03519a78d4d9ecce9f89f5be669e5 (diff) | |
| download | bitcoin-700576649269d6e7d730b525950bc8f6cdf9a927.tar.xz | |
Merge bitcoin/bitcoin#29299: validation: fix misleading checkblockindex comments
9819db4ccaa03519a78d4d9ecce9f89f5be669e5 validation: move nChainTx assert down in CheckBlockIndex (Martin Zumsande)
033477dba65151b1863214606d5a49686ab6f559 doc: fix checkblockindex comments (Martin Zumsande)
Pull request description:
The two assumptions there were described as test-only, which has led to confusion whether they should exist.
However, they are necessary in general, as the changed comment explains - without them, the check would fail everywhere where it is enabled.
The second commit moves this assert down to the other checks.
Closes #29261
ACKs for top commit:
maflcko:
ACK 9819db4ccaa03519a78d4d9ecce9f89f5be669e5 🌦
naumenkogs:
ACK 9819db4ccaa03519a78d4d9ecce9f89f5be669e5
ryanofsky:
Code review ACK 9819db4ccaa03519a78d4d9ecce9f89f5be669e5. Thanks for figuring this issue out and fixing it. Would suggest changing pr name from "improve comments" to "fix misleading comments" since previous comments were wrong about the reasons the conditions are needed.
Tree-SHA512: 3f77791253eb0c97f8153dd8ae1c567f43f6387ea7a53efea94817463c672a4e11d548aa7eff62235346ff0713ff4d6fe08f9ec50d0c30a1e6b6d27b9918b419
Diffstat (limited to 'src/node')
0 files changed, 0 insertions, 0 deletions