diff options
| author | fanquake <fanquake@gmail.com> | 2022-10-03 18:06:38 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2022-10-03 18:16:10 +0100 |
| commit | b92b12e8f3ea1e318e428e9c2ca0d529fd4452d2 (patch) | |
| tree | 253b0bcf5d128d17453b5bac1085eedcf03edbd9 /src/node/caches.cpp | |
| parent | 3baa0f5a603cedd66442492346583f2b3d776db7 (diff) | |
| parent | 9cbfe40d8af8567682284890c080b0c3cf434490 (diff) | |
Merge bitcoin/bitcoin#25735: net: remove useless call to IsReachable() from CConnman::Bind()
9cbfe40d8af8567682284890c080b0c3cf434490 net: remove useless call to IsReachable() from CConnman::Bind() (Vasil Dimov)
Pull request description:
`CConnman::Bind()` is called without `BF_EXPLICIT` only when passed
either `0.0.0.0` or `::`. For those addresses `IsReachable()` is always
true (regardless of the `-onlynet=` setting!), meaning that the `if`
condition never evaluates to true.
`IsReachable()` is always true for the "any" IPv4 and IPv6 addresses
because `CNetAddr::GetNetwork()` returns `NET_UNROUTABLE` instead of
`NET_IPV4` or `NET_IPV6` and the network `NET_UNROUTABLE` is always
considered reachable.
It follows that `BF_EXPLICIT` is unnecessary, remove it too.
ACKs for top commit:
naumenkogs:
ACK 9cbfe40d8af8567682284890c080b0c3cf434490
aureleoules:
ACK 9cbfe40d8af8567682284890c080b0c3cf434490
mzumsande:
ACK 9cbfe40d8af8567682284890c080b0c3cf434490
Tree-SHA512: 4e53ee8a73ddd133fd4ff25635135b65e5c19d1fc56fe5c30337406560664616c0adff414dca47602948919f34c81073aae6bfc2871509f3912663d86750928e
Diffstat (limited to 'src/node/caches.cpp')
0 files changed, 0 insertions, 0 deletions