diff options
| author | Ava Chow <github@achow101.com> | 2024-01-16 12:38:50 -0500 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-01-16 12:49:09 -0500 |
| commit | 27d935f58b9ef5560ddd5914547a6de7884c41e6 (patch) | |
| tree | 65d47fc63d2504e6fe8d812aaa673067b496e09a /src/net_processing.cpp | |
| parent | f1fcc9638cde7664b9642018fe6872148bbb0172 (diff) | |
| parent | df30247705940c50c5eaafd74e2abbeb8b0cec07 (diff) | |
Merge bitcoin/bitcoin#29179: test: wallet rescan with reorged parent + IsFromMe child in mempool
df30247705940c50c5eaafd74e2abbeb8b0cec07 [test] import descriptor wallet with reorged parent + IsFromMe child in mempool (glozow)
c3d02be536ac3f35c10efa03653186a17ebbfc12 [test] rescan legacy wallet with reorged parent + IsFromMe child in mempool (Gloria Zhao)
Pull request description:
Originally motivated by #29019, which reverts back to having `requestMempoolTransactions` emit `transactionAddedToMempool` in `mapTx` default order instead of `GetSortedDepthAndScore` order.
It's important that these notifications happen in topological order, otherwise the wallet rescan may miss transactions that belong to it. Notably, checking whether a transaction `IsFromMe` requires knowing its inputs, which may be from a mempool parent.
When using `mapTx` order, a parent may come later than its child if it was added from a block disconnected in a reorg.
This PR adds a test for this case.
ACKs for top commit:
achow101:
ACK df30247705940c50c5eaafd74e2abbeb8b0cec07
furszy:
Code review ACK df30247705, nits can be disregarded.
Tree-SHA512: 2f1d9ef92313228adbbef94e634e5f7a9ec6e6a2c88e16aa343bdc95ffc9b9f9c82a569b412c9a3841db9d789e52f9283e8b9385731668d59355903e26e58a5d
Diffstat (limited to 'src/net_processing.cpp')
0 files changed, 0 insertions, 0 deletions