diff options
author | Pieter Wuille <pieter@wuille.net> | 2020-12-15 09:56:53 -0800 |
---|---|---|
committer | Pieter Wuille <pieter@wuille.net> | 2020-12-15 12:45:32 -0800 |
commit | 83f8821a6f41854edd5c0b11deabba658890cde1 (patch) | |
tree | 0b1468ad1cad92dc903c0f4e18e1024e9688a3cc /src/net.h | |
parent | d9a4738c9d3d3c8c8a0ca4e7ee6ced721da15d53 (diff) | |
download | bitcoin-83f8821a6f41854edd5c0b11deabba658890cde1.tar.xz |
refactor: add IsAddrCompatible() to CNode
Diffstat (limited to 'src/net.h')
-rw-r--r-- | src/net.h | 17 |
1 files changed, 11 insertions, 6 deletions
@@ -1176,18 +1176,23 @@ public: m_addr_known->insert(_addr.GetKey()); } - void PushAddress(const CAddress& _addr, FastRandomContext &insecure_rand) + /** + * Whether the peer supports the address. For example, a peer that does not + * implement BIP155 cannot receive Tor v3 addresses because it requires + * ADDRv2 (BIP155) encoding. + */ + bool IsAddrCompatible(const CAddress& addr) const { - // Whether the peer supports the address in `_addr`. For example, - // nodes that do not implement BIP155 cannot receive Tor v3 addresses - // because they require ADDRv2 (BIP155) encoding. - const bool addr_format_supported = m_wants_addrv2 || _addr.IsAddrV1Compatible(); + return m_wants_addrv2 || addr.IsAddrV1Compatible(); + } + void PushAddress(const CAddress& _addr, FastRandomContext &insecure_rand) + { // Known checking here is only to save space from duplicates. // SendMessages will filter it again for knowns that were added // after addresses were pushed. assert(m_addr_known); - if (_addr.IsValid() && !m_addr_known->contains(_addr.GetKey()) && addr_format_supported) { + if (_addr.IsValid() && !m_addr_known->contains(_addr.GetKey()) && IsAddrCompatible(_addr)) { if (vAddrToSend.size() >= MAX_ADDR_TO_SEND) { vAddrToSend[insecure_rand.randrange(vAddrToSend.size())] = _addr; } else { |