refactor: Initialize magic bytes in constructor initializer

Also remove an assert that is already enforced by the compiler checking
that the length of the std::array matches.

1 files changed, 1 insertions, 3 deletions

diff --git a/src/net.cpp b/src/net.cpp
index 4aee78846a..a2f80cbcf7 100644
--- a/src/net.cpp
+++ b/src/net.cpp
@@ -684,10 +684,8 @@ bool CNode::ReceiveMsgBytes(Span<const uint8_t> msg_bytes, bool& complete)
 }
 
 V1Transport::V1Transport(const NodeId node_id, int nTypeIn, int nVersionIn) noexcept :
-    m_node_id(node_id), hdrbuf(nTypeIn, nVersionIn), vRecv(nTypeIn, nVersionIn)
+    m_magic_bytes{Params().MessageStart()}, m_node_id(node_id), hdrbuf(nTypeIn, nVersionIn), vRecv(nTypeIn, nVersionIn)
 {
-    assert(std::size(Params().MessageStart()) == std::size(m_magic_bytes));
-    m_magic_bytes = Params().MessageStart();
     LOCK(m_recv_mutex);
     Reset();
 }