diff options
| author | fanquake <fanquake@gmail.com> | 2023-10-02 13:55:56 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-10-02 14:07:20 +0100 |
| commit | 8909667ab8a65478e0eaa6495299305ad836e835 (patch) | |
| tree | 102747fa2b924414fec6e734c0f0b256e63f702a /src/key_io.cpp | |
| parent | 50f250a67dcc6450abaac2598be0beb86b9e7a48 (diff) | |
| parent | 380130d9d70f8f8d395949a51f43806f6e600efa (diff) | |
Merge bitcoin/bitcoin#28176: tests: add coverage to feature_addrman.py
380130d9d70f8f8d395949a51f43806f6e600efa test: add coverage to feature_addrman.py (kevkevin)
Pull request description:
I added two new tests that will cover the nNew and nTried tests which add coverage to the if block by checking values larger than our range since we only check for negative values now
adding coverage to these lines
https://github.com/bitcoin/bitcoin/blob/master/src/addrman.cpp#L273
https://github.com/bitcoin/bitcoin/blob/master/src/addrman.cpp#L280
our test seem to only cover the `nTried < 0` and `nNew < 0` scenarios
ACKs for top commit:
ismaelsadeeq:
ACK 380130d9d70f8f8d395949a51f43806f6e600efa, code looks good to me 🍃 .
0xB10C:
Re-ACK 380130d9d70f8f8d395949a51f43806f6e600efa
Tree-SHA512: a063bd9ca4d2d536a27c8c22a28fb13759a96f19cd8ba6cb8879cf7f65046d4ff6e8f70df17feaffd0d0d08ef914cb18a11258d313a4841c811a7e7ae4df6d5b
Diffstat (limited to 'src/key_io.cpp')
0 files changed, 0 insertions, 0 deletions