diff options
| author | Antoine Riard <ariard@student.42.fr> | 2019-07-30 18:08:03 -0400 |
|---|---|---|
| committer | Antoine Riard <ariard@student.42.fr> | 2019-08-08 22:57:35 -0400 |
| commit | b7b9f6e4cee262004643e2fe03d56cb47fdbf5c2 (patch) | |
| tree | 2f568f5e17b75577645a2b00159baed7c9833651 /src/interfaces | |
| parent | e5fdda68c6d2313edb74443f0d1e6d2ce2d97f5e (diff) | |
| download | bitcoin-b7b9f6e4cee262004643e2fe03d56cb47fdbf5c2.tar.xz | |
Remove p2pEnabled from Chain interface
RPC server starts in warmup mode, it can't
process yet calls, then follows connection manager
initialization and finally RPC server get out of
warmup mode. RPC calls shouldn't be able to get
P2P disabled errors because once we initialize
g_connman it's not unset until shutdown, after
RPC server has been stopped.
Diffstat (limited to 'src/interfaces')
| -rw-r--r-- | src/interfaces/chain.cpp | 1 | ||||
| -rw-r--r-- | src/interfaces/chain.h | 3 |
2 files changed, 0 insertions, 4 deletions
diff --git a/src/interfaces/chain.cpp b/src/interfaces/chain.cpp index 1ad4308f29..b8b9ecded9 100644 --- a/src/interfaces/chain.cpp +++ b/src/interfaces/chain.cpp @@ -332,7 +332,6 @@ public: LOCK(cs_main); return ::fHavePruned; } - bool p2pEnabled() override { return g_connman != nullptr; } bool isReadyToBroadcast() override { return !::fImporting && !::fReindex && !isInitialBlockDownload(); } bool isInitialBlockDownload() override { return ::ChainstateActive().IsInitialBlockDownload(); } bool shutdownRequested() override { return ShutdownRequested(); } diff --git a/src/interfaces/chain.h b/src/interfaces/chain.h index 1d6ed05522..da670a3370 100644 --- a/src/interfaces/chain.h +++ b/src/interfaces/chain.h @@ -187,9 +187,6 @@ public: //! Check if any block has been pruned. virtual bool havePruned() = 0; - //! Check if p2p enabled. - virtual bool p2pEnabled() = 0; - //! Check if the node is ready to broadcast transactions. virtual bool isReadyToBroadcast() = 0; |