diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-05-26 17:05:01 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-05-26 17:05:10 +0200 |
| commit | 2642dee1364ddc9b174e0ccb6b7b37ae44899c2a (patch) | |
| tree | 9872721447fff5fd4d9c6d0979412e158b9fedfc /src/init.cpp | |
| parent | 48eec32347494da781f26478fa488b28336afbd2 (diff) | |
| parent | f9fdcec7e932843a91ddf7f377e00bd2a6efb82a (diff) | |
| download | bitcoin-2642dee1364ddc9b174e0ccb6b7b37ae44899c2a.tar.xz | |
Merge bitcoin/bitcoin#15936: interfaces: Expose settings.json methods to GUI
f9fdcec7e932843a91ddf7f377e00bd2a6efb82a settings: Add resetSettings() method (Ryan Ofsky)
77fabffef4ea840ee15c97061048fe8443d74658 init: Remove Shutdown() node.args reset (Ryan Ofsky)
0e55bc6e7fe439404dc56093a0949395dae51e6b settings: Add update/getPersistent/isIgnored methods (Ryan Ofsky)
Pull request description:
Add `interfaces::Node` `updateSetting`, `forceSetting`, `resetSettings`, `isSettingIgnored`, and `getPersistentSetting` methods so GUI is able to manipulate `settings.json` file and use and modify node settings.
(Originally this PR also contained GUI changes to unify bitcoin-qt and bitcoind persistent settings and call these methods, but the GUI commits have been dropped from this PR and moved to bitcoin-core/gui/pull/602)
ACKs for top commit:
vasild:
ACK f9fdcec7e932843a91ddf7f377e00bd2a6efb82a
hebasto:
re-ACK f9fdcec7e932843a91ddf7f377e00bd2a6efb82a, only a function renamed since my recent [review](https://github.com/bitcoin/bitcoin/pull/15936#pullrequestreview-979324357).
Tree-SHA512: 4cac853ee29be96d2ff38404165b9dfb7c622b2a9c99a15979596f3484ffde0da3d9c9c372677dff5119ca7cffa6383d81037fd9889a29cc9285882a8dc0c268
Diffstat (limited to 'src/init.cpp')
| -rw-r--r-- | src/init.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/init.cpp b/src/init.cpp index e436d5ea8e..35e9aa1443 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -319,7 +319,6 @@ void Shutdown(NodeContext& node) LogPrintf("%s: Unable to remove PID file: %s\n", __func__, fsbridge::get_filesystem_error_message(e)); } - node.args = nullptr; LogPrintf("%s: done\n", __func__); } |