diff options
| author | fanquake <fanquake@gmail.com> | 2023-09-12 09:30:59 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-09-12 09:44:55 +0100 |
| commit | fd69ffbbfb3e08b474b33540e56cf4f81e5c21d4 (patch) | |
| tree | 2aee83004ff19e33c9e9356c4ce6d61a8a0d8b1f /src/index/blockfilterindex.cpp | |
| parent | 8f7b9eb8711fdb32e8bdb59d2a7462a46c7a8086 (diff) | |
| parent | c0bf667912064960df194ea94150976b34f7c267 (diff) | |
| download | bitcoin-fd69ffbbfb3e08b474b33540e56cf4f81e5c21d4.tar.xz | |
Merge bitcoin/bitcoin#28427: index: coinstats reorg, fail when block cannot be reversed
c0bf667912064960df194ea94150976b34f7c267 index: add [nodiscard] attribute to functions writing to the db (furszy)
eef595560e9ecf3a0d1db4d8ea7ecc33a49d839f index: coinstats reorg, fail when block cannot be reversed (furszy)
Pull request description:
Found it while reviewing https://github.com/bitcoin/bitcoin/pull/24230#discussion_r1310863359.
During a reorg, continuing execution when a block cannot be reversed leaves the
coinstats index in an inconsistent state.
This was surely overlooked when 'CustomRewind' was implemented.
ACKs for top commit:
ryanofsky:
Code review ACK c0bf667912064960df194ea94150976b34f7c267. Only change since last review is new commit adding [[nodiscard]]
Tree-SHA512: f4fc8522508d23e4fff09a29c935971819b1bd3b2a260e08e2e2b72f9340980d74fbec742a58fe216baf61d27de057c7c8300e8fa075f8507cd1227f128af909
Diffstat (limited to 'src/index/blockfilterindex.cpp')
| -rw-r--r-- | src/index/blockfilterindex.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/index/blockfilterindex.cpp b/src/index/blockfilterindex.cpp index 21132d9305..5fda798efd 100644 --- a/src/index/blockfilterindex.cpp +++ b/src/index/blockfilterindex.cpp @@ -261,7 +261,7 @@ bool BlockFilterIndex::CustomAppend(const interfaces::BlockInfo& block) return true; } -static bool CopyHeightIndexToHashIndex(CDBIterator& db_it, CDBBatch& batch, +[[nodiscard]] static bool CopyHeightIndexToHashIndex(CDBIterator& db_it, CDBBatch& batch, const std::string& index_name, int start_height, int stop_height) { |