diff options
author | MacroFake <falke.marco@gmail.com> | 2022-07-26 17:47:50 +0200 |
---|---|---|
committer | MacroFake <falke.marco@gmail.com> | 2022-07-26 17:47:55 +0200 |
commit | 7f79746bf046d0028bb68f265804b9774dec2acb (patch) | |
tree | 933234af65f8d6aafdc3c7953f0e11c759acc24c /src/external_signer.cpp | |
parent | 567121747712612434223679d77557a7edf0fe56 (diff) | |
parent | 49168df073d465450b1da4a506ac7ea24fbbb877 (diff) | |
download | bitcoin-7f79746bf046d0028bb68f265804b9774dec2acb.tar.xz |
Merge bitcoin/bitcoin#25705: tidy: enable readability-redundant-string-init
49168df073d465450b1da4a506ac7ea24fbbb877 tidy: enable readability-redundant-string-init (fanquake)
4ddd746bf9714a209b2f82918a70c4fe81d895c9 refactor: remove unnecessary string initializations (fanquake)
Pull request description:
Remove unnecessary `std::string` = "" initializations. Enable `readability-redundant-string-init`.
See:
https://releases.llvm.org/14.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-redundant-string-init.html
ACKs for top commit:
shaavan:
ACK 49168df073d465450b1da4a506ac7ea24fbbb87
Tree-SHA512: 69e72a434908c9166d407551657b310361ae2ef0170f8289cb1c2b8e96a4632be718c0d55cb12af03a3c3d621d9583eced88e5e9d924abb0a8b1a9b36c903d66
Diffstat (limited to 'src/external_signer.cpp')
-rw-r--r-- | src/external_signer.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/external_signer.cpp b/src/external_signer.cpp index d125fe479b..6bab0a856c 100644 --- a/src/external_signer.cpp +++ b/src/external_signer.cpp @@ -49,7 +49,7 @@ bool ExternalSigner::Enumerate(const std::string& command, std::vector<ExternalS if (signer.m_fingerprint.compare(fingerprintStr) == 0) duplicate = true; } if (duplicate) break; - std::string name = ""; + std::string name; const UniValue& model_field = find_value(signer, "model"); if (model_field.isStr() && model_field.getValStr() != "") { name += model_field.getValStr(); |